Bug 1573362 - update a copy for some of the text label checks messages. r=mtigley,fluent-reviewers,flod
authorYura Zenevich <yura.zenevich@gmail.com>
Thu, 15 Aug 2019 15:15:40 +0000
changeset 488291 43d96432677f15bb68ebc9edebdcf83ec59be7ec
parent 488290 7f41e2dd2f998cbb4f533a8fec9046e7b8aeb147
child 488292 b57a45d3b47642f3f1294e3e0151f8b018b00453
push id113906
push userncsoregi@mozilla.com
push dateFri, 16 Aug 2019 04:07:24 +0000
treeherdermozilla-inbound@d887276421d3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmtigley, fluent-reviewers, flod
bugs1573362
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1573362 - update a copy for some of the text label checks messages. r=mtigley,fluent-reviewers,flod Differential Revision: https://phabricator.services.mozilla.com/D41750
devtools/client/accessibility/components/TextLabelCheck.js
devtools/client/locales/en-US/accessibility.ftl
devtools/server/actors/highlighters/utils/accessibility.js
devtools/shared/locales/en-US/accessibility.properties
--- a/devtools/client/accessibility/components/TextLabelCheck.js
+++ b/devtools/client/accessibility/components/TextLabelCheck.js
@@ -99,17 +99,17 @@ const ISSUE_TO_ANNOTATION_MAP = {
     args: {
       get code() {
         return ReactDOM.code({}, "fieldset");
       },
     },
   },
   [FORM_FIELDSET_NO_NAME_FROM_LEGEND]: {
     href: A11Y_TEXT_LABEL_LINKS.FORM_FIELDSET_NO_NAME_FROM_LEGEND,
-    l10nId: "accessibility-text-label-issue-fieldset-legend",
+    l10nId: "accessibility-text-label-issue-fieldset-legend2",
     args: {
       get code() {
         return ReactDOM.code({}, "legend");
       },
       // Note: there is no way right now to use custom elements in privileged
       // content. We have to use something like <span> since we can't provide
       // two args with the same name.
       get span() {
@@ -122,17 +122,17 @@ const ISSUE_TO_ANNOTATION_MAP = {
     l10nId: "accessibility-text-label-issue-form",
   },
   [FORM_NO_VISIBLE_NAME]: {
     href: A11Y_TEXT_LABEL_LINKS.FORM_NO_VISIBLE_NAME,
     l10nId: "accessibility-text-label-issue-form-visible",
   },
   [FORM_OPTGROUP_NO_NAME_FROM_LABEL]: {
     href: A11Y_TEXT_LABEL_LINKS.FORM_OPTGROUP_NO_NAME_FROM_LABEL,
-    l10nId: "accessibility-text-label-issue-optgroup-label",
+    l10nId: "accessibility-text-label-issue-optgroup-label2",
     args: {
       get code() {
         return ReactDOM.code({}, "label");
       },
       // Note: there is no way right now to use custom elements in privileged
       // content. We have to use something like <span> since we can't provide
       // two args with the same name.
       get span() {
--- a/devtools/client/locales/en-US/accessibility.ftl
+++ b/devtools/client/locales/en-US/accessibility.ftl
@@ -30,17 +30,17 @@ accessibility-text-label-issue-dialog = 
 accessibility-text-label-issue-document-title = Documents must have a <code>title</code>. <a>Learn more</a>
 
 accessibility-text-label-issue-embed = Embedded content must be labeled. <a>Learn more</a>
 
 accessibility-text-label-issue-figure = Figures with optional captions should be labeled. <a>Learn more</a>
 
 accessibility-text-label-issue-fieldset = <code>fieldset</code> elements must be labeled. <a>Learn more</a>
 
-accessibility-text-label-issue-fieldset-legend = Use <code>legend</code> element to label <span>fieldset</span> elements. <a>Learn more</a>
+accessibility-text-label-issue-fieldset-legend2 = Use a <code>legend</code> element to label a <span>fieldset</span>. <a>Learn more</a>
 
 accessibility-text-label-issue-form = Form elements must be labeled. <a>Learn more</a>
 
 accessibility-text-label-issue-form-visible = Form elements should have a visible text label. <a>Learn more</a>
 
 accessibility-text-label-issue-frame = <code>frame</code> elements must be labeled. <a>Learn more</a>
 
 accessibility-text-label-issue-glyph = Use <code>alt</code> attribute to label <span>mglyph</span> elements. <a>Learn more</a>
@@ -50,11 +50,11 @@ accessibility-text-label-issue-heading =
 accessibility-text-label-issue-heading-content = Headings should have visible text content. <a>Learn more</a>
 
 accessibility-text-label-issue-iframe = Use <code>title</code> attribute to describe <span>iframe</span> content. <a>Learn more</a>
 
 accessibility-text-label-issue-image = Content with images must be labeled. <a>Learn more</a>
 
 accessibility-text-label-issue-interactive = Interactive elements must be labeled. <a>Learn more</a>
 
-accessibility-text-label-issue-optgroup-label = Use <code>label</code> attribute to label <span>optgroup</span> elements. <a>Learn more</a>
+accessibility-text-label-issue-optgroup-label2 = Use a <code>label</code> attribute to label an <span>optgroup</span>. <a>Learn more</a>
 
 accessibility-text-label-issue-toolbar = Toolbars must be labeled when there is more than one toolbar. <a>Learn more</a>
--- a/devtools/server/actors/highlighters/utils/accessibility.js
+++ b/devtools/server/actors/highlighters/utils/accessibility.js
@@ -671,21 +671,21 @@ class TextLabel extends AuditReport {
     return {
       [AREA_NO_NAME_FROM_ALT]: "accessibility.text.label.issue.area",
       [DIALOG_NO_NAME]: "accessibility.text.label.issue.dialog",
       [DOCUMENT_NO_TITLE]: "accessibility.text.label.issue.document.title",
       [EMBED_NO_NAME]: "accessibility.text.label.issue.embed",
       [FIGURE_NO_NAME]: "accessibility.text.label.issue.figure",
       [FORM_FIELDSET_NO_NAME]: "accessibility.text.label.issue.fieldset",
       [FORM_FIELDSET_NO_NAME_FROM_LEGEND]:
-        "accessibility.text.label.issue.fieldset.legend",
+        "accessibility.text.label.issue.fieldset.legend2",
       [FORM_NO_NAME]: "accessibility.text.label.issue.form",
       [FORM_NO_VISIBLE_NAME]: "accessibility.text.label.issue.form.visible",
       [FORM_OPTGROUP_NO_NAME_FROM_LABEL]:
-        "accessibility.text.label.issue.optgroup.label",
+        "accessibility.text.label.issue.optgroup.label2",
       [FRAME_NO_NAME]: "accessibility.text.label.issue.frame",
       [HEADING_NO_CONTENT]: "accessibility.text.label.issue.heading.content",
       [HEADING_NO_NAME]: "accessibility.text.label.issue.heading",
       [IFRAME_NO_NAME_FROM_TITLE]: "accessibility.text.label.issue.iframe",
       [IMAGE_NO_NAME]: "accessibility.text.label.issue.image",
       [INTERACTIVE_NO_NAME]: "accessibility.text.label.issue.interactive",
       [MATHML_GLYPH_NO_NAME]: "accessibility.text.label.issue.glyph",
       [TOOLBAR_NO_NAME]: "accessibility.text.label.issue.toolbar",
--- a/devtools/shared/locales/en-US/accessibility.properties
+++ b/devtools/shared/locales/en-US/accessibility.properties
@@ -45,20 +45,20 @@ accessibility.text.label.issue.embed = E
 # provided.
 accessibility.text.label.issue.figure = Figures with optional captions should be labeled.
 
 # LOCALIZATION NOTE (accessibility.text.label.issue.fieldset): A title text that
 # describes that currently selected accessible object for a <fieldset> must have a name
 # provided.
 accessibility.text.label.issue.fieldset = “fieldset” elements must be labeled.
 
-# LOCALIZATION NOTE (accessibility.text.label.issue.fieldset.legend): A title text that
+# LOCALIZATION NOTE (accessibility.text.label.issue.fieldset.legend2): A title text that
 # describes that currently selected accessible object for a <fieldset> must have a name
 # provided via <legend> element.
-accessibility.text.label.issue.fieldset.legend = Use “legend” element to label “fieldset” elements.
+accessibility.text.label.issue.fieldset.legend2 = Use a “legend” element to label a “fieldset”.
 
 # LOCALIZATION NOTE (accessibility.text.label.issue.form): A title text that
 # describes that currently selected accessible object for a form element must have a name
 # provided.
 accessibility.text.label.issue.form = Form elements must be labeled.
 
 # LOCALIZATION NOTE (accessibility.text.label.issue.form.visible): A title text that
 # describes that currently selected accessible object for a form element should have a name
@@ -95,17 +95,17 @@ accessibility.text.label.issue.iframe = Use “title” attribute to describe “iframe” content.
 # name provided.
 accessibility.text.label.issue.image = Content with images must be labeled.
 
 # LOCALIZATION NOTE (accessibility.text.label.issue.interactive): A title text that
 # describes that currently selected accessible object for interactive element must have a
 # name provided.
 accessibility.text.label.issue.interactive = Interactive elements must be labeled.
 
-# LOCALIZATION NOTE (accessibility.text.label.issue.optgroup.label): A title text that
+# LOCALIZATION NOTE (accessibility.text.label.issue.optgroup.label2): A title text that
 # describes that currently selected accessible object for an <optgroup> must have a
 # name provided via label attribute.
-accessibility.text.label.issue.optgroup.label = Use “label” attribute to label “optgroup” elements.
+accessibility.text.label.issue.optgroup.label2 = Use a “label” attribute to label an “optgroup”.
 
 # LOCALIZATION NOTE (accessibility.text.label.issue.toolbar): A title text that
 # describes that currently selected accessible object for a toolbar must have a
 # name provided when there is more than one toolbar in the document.
 accessibility.text.label.issue.toolbar = Toolbars must be labeled when there is more than one toolbar.