Bug 963651 - Strip C++ unit tests even when STRIP_FLAGS are unset; r=mshal CLOSED TREE
authorTed Mielczarek <ted@mielczarek.org>
Fri, 24 Jan 2014 12:57:23 -0500
changeset 165343 431612fab17e3d05cc4b2f976ac3f6f517051f70
parent 165342 270335b8f81a76a04f31f55221cb015319cfacee
child 165344 1cea61b9730f5ff54706f46f77ec625a23127f03
child 165400 ab2609380aff727a2dc86650bea74246d1cabe34
push id38953
push useremorley@mozilla.com
push dateMon, 27 Jan 2014 18:02:57 +0000
treeherdermozilla-inbound@431612fab17e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmshal
bugs963651
milestone29.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 963651 - Strip C++ unit tests even when STRIP_FLAGS are unset; r=mshal CLOSED TREE
testing/testsuite-targets.mk
--- a/testing/testsuite-targets.mk
+++ b/testing/testsuite-targets.mk
@@ -492,17 +492,17 @@ ifdef OBJCOPY
 ifndef PKG_SKIP_STRIP
 STRIP_CPP_TESTS := 1
 endif
 endif
 
 stage-cppunittests:
 	$(NSINSTALL) -D $(PKG_STAGE)/cppunittests
 ifdef STRIP_CPP_TESTS
-	$(foreach bin,$(CPP_UNIT_TEST_BINS),$(OBJCOPY) $(STRIP_FLAGS) $(bin) $(bin:$(DIST)/%=$(PKG_STAGE)/%);)
+	$(foreach bin,$(CPP_UNIT_TEST_BINS),$(OBJCOPY) $(or $(STRIP_FLAGS),--strip-unneeded) $(bin) $(bin:$(DIST)/%=$(PKG_STAGE)/%);)
 else
 	cp -RL $(DIST)/cppunittests $(PKG_STAGE)
 endif
 	$(NSINSTALL) $(topsrcdir)/testing/runcppunittests.py $(PKG_STAGE)/cppunittests
 	$(NSINSTALL) $(topsrcdir)/testing/remotecppunittests.py $(PKG_STAGE)/cppunittests
 ifeq ($(MOZ_WIDGET_TOOLKIT),android)
 	$(NSINSTALL) $(topsrcdir)/testing/android_cppunittest_manifest.txt $(PKG_STAGE)/cppunittests
 endif