Bug 1229028 - remove #ifdef NS_BUILD_REFCNT_LOGGING methods from nsXULPrototypeNode; r=bz
authorNathan Froyd <froydnj@mozilla.com>
Mon, 30 Nov 2015 10:15:44 -0500
changeset 274899 42d9f12af41a7491bfde4875ac6fc44a0c77afa1
parent 274898 14ea3aec5d8492396eac15b547f9e6efe5f18a27
child 274900 fe7c4e4d145119da9e35b29214078e8b6b6acee9
push id68717
push usernfroyd@mozilla.com
push dateTue, 01 Dec 2015 14:03:12 +0000
treeherdermozilla-inbound@42d9f12af41a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbz
bugs1229028
milestone45.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1229028 - remove #ifdef NS_BUILD_REFCNT_LOGGING methods from nsXULPrototypeNode; r=bz These methods are subsumed by the automatic generation of AddRef/Release methods featuring the class name, and are not called in any event.
dom/xul/nsXULElement.h
--- a/dom/xul/nsXULElement.h
+++ b/dom/xul/nsXULElement.h
@@ -119,21 +119,16 @@ public:
     virtual nsresult Serialize(nsIObjectOutputStream* aStream,
                                nsXULPrototypeDocument* aProtoDoc,
                                const nsTArray<RefPtr<mozilla::dom::NodeInfo>> *aNodeInfos) = 0;
     virtual nsresult Deserialize(nsIObjectInputStream* aStream,
                                  nsXULPrototypeDocument* aProtoDoc,
                                  nsIURI* aDocumentURI,
                                  const nsTArray<RefPtr<mozilla::dom::NodeInfo>> *aNodeInfos) = 0;
 
-#ifdef NS_BUILD_REFCNT_LOGGING
-    virtual const char* ClassName() = 0;
-    virtual uint32_t ClassSize() = 0;
-#endif
-
     /**
      * The prototype document must call ReleaseSubtree when it is going
      * away.  This makes the parents through the tree stop owning their
      * children, whether or not the parent's reference count is zero.
      * Individual elements may still own individual prototypes, but
      * those prototypes no longer remember their children to allow them
      * to be constructed.
      */
@@ -161,21 +156,16 @@ public:
     {
     }
 
     virtual ~nsXULPrototypeElement()
     {
         Unlink();
     }
 
-#ifdef NS_BUILD_REFCNT_LOGGING
-    virtual const char* ClassName() override { return "nsXULPrototypeElement"; }
-    virtual uint32_t ClassSize() override { return sizeof(*this); }
-#endif
-
     virtual void ReleaseSubtree() override
     {
         for (int32_t i = mChildren.Length() - 1; i >= 0; i--) {
             if (mChildren[i].get())
                 mChildren[i]->ReleaseSubtree();
         }
         mChildren.Clear();
         nsXULPrototypeNode::ReleaseSubtree();
@@ -214,21 +204,16 @@ class XULDocument;
 } // namespace mozilla
 
 class nsXULPrototypeScript : public nsXULPrototypeNode
 {
 public:
     nsXULPrototypeScript(uint32_t aLineNo, uint32_t version);
     virtual ~nsXULPrototypeScript();
 
-#ifdef NS_BUILD_REFCNT_LOGGING
-    virtual const char* ClassName() override { return "nsXULPrototypeScript"; }
-    virtual uint32_t ClassSize() override { return sizeof(*this); }
-#endif
-
     virtual nsresult Serialize(nsIObjectOutputStream* aStream,
                                nsXULPrototypeDocument* aProtoDoc,
                                const nsTArray<RefPtr<mozilla::dom::NodeInfo>> *aNodeInfos) override;
     nsresult SerializeOutOfLine(nsIObjectOutputStream* aStream,
                                 nsXULPrototypeDocument* aProtoDoc);
     virtual nsresult Deserialize(nsIObjectInputStream* aStream,
                                  nsXULPrototypeDocument* aProtoDoc,
                                  nsIURI* aDocumentURI,
@@ -293,21 +278,16 @@ public:
         : nsXULPrototypeNode(eType_Text)
     {
     }
 
     virtual ~nsXULPrototypeText()
     {
     }
 
-#ifdef NS_BUILD_REFCNT_LOGGING
-    virtual const char* ClassName() override { return "nsXULPrototypeText"; }
-    virtual uint32_t ClassSize() override { return sizeof(*this); }
-#endif
-
     virtual nsresult Serialize(nsIObjectOutputStream* aStream,
                                nsXULPrototypeDocument* aProtoDoc,
                                const nsTArray<RefPtr<mozilla::dom::NodeInfo>> *aNodeInfos) override;
     virtual nsresult Deserialize(nsIObjectInputStream* aStream,
                                  nsXULPrototypeDocument* aProtoDoc,
                                  nsIURI* aDocumentURI,
                                  const nsTArray<RefPtr<mozilla::dom::NodeInfo>> *aNodeInfos) override;
 
@@ -321,21 +301,16 @@ public:
         : nsXULPrototypeNode(eType_PI)
     {
     }
 
     virtual ~nsXULPrototypePI()
     {
     }
 
-#ifdef NS_BUILD_REFCNT_LOGGING
-    virtual const char* ClassName() override { return "nsXULPrototypePI"; }
-    virtual uint32_t ClassSize() override { return sizeof(*this); }
-#endif
-
     virtual nsresult Serialize(nsIObjectOutputStream* aStream,
                                nsXULPrototypeDocument* aProtoDoc,
                                const nsTArray<RefPtr<mozilla::dom::NodeInfo>> *aNodeInfos) override;
     virtual nsresult Deserialize(nsIObjectInputStream* aStream,
                                  nsXULPrototypeDocument* aProtoDoc,
                                  nsIURI* aDocumentURI,
                                  const nsTArray<RefPtr<mozilla::dom::NodeInfo>> *aNodeInfos) override;