Bug 1164834: MessageEvents coming from postMessage should not be cancelable. r=Ms2ger
authorKyle Huey <khuey@kylehuey.com>
Tue, 25 Aug 2015 13:30:19 -0700
changeset 259305 42a4c4b8d8534268ba1ef26ac0ec89df0ce4b6dc
parent 259304 098eb95181a38733dcbc05acdef699502aae1fb8
child 259306 793bc02002203267dfa825221fe0b6a18faf54ad
push id64197
push userkhuey@mozilla.com
push dateTue, 25 Aug 2015 20:37:52 +0000
treeherdermozilla-inbound@42a4c4b8d853 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersMs2ger
bugs1164834
milestone43.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1164834: MessageEvents coming from postMessage should not be cancelable. r=Ms2ger
dom/workers/WorkerPrivate.cpp
testing/web-platform/meta/workers/interfaces/DedicatedWorkerGlobalScope/postMessage/message-event.html.ini
--- a/dom/workers/WorkerPrivate.cpp
+++ b/dom/workers/WorkerPrivate.cpp
@@ -1142,17 +1142,17 @@ public:
       xpc::Throw(aCx, NS_ERROR_DOM_DATA_CLONE_ERR);
       return false;
     }
 
     nsRefPtr<MessageEvent> event = new MessageEvent(aTarget, nullptr, nullptr);
     nsresult rv =
       event->InitMessageEvent(NS_LITERAL_STRING("message"),
                               false /* non-bubbling */,
-                              true /* cancelable */,
+                              false /* non-cancelable */,
                               messageData,
                               EmptyString(),
                               EmptyString(),
                               nullptr);
     if (mEventSource) {
       nsRefPtr<ServiceWorkerClient> client =
         new ServiceWorkerWindowClient(aTarget, *mEventSource);
       event->SetSource(client);
deleted file mode 100644
--- a/testing/web-platform/meta/workers/interfaces/DedicatedWorkerGlobalScope/postMessage/message-event.html.ini
+++ /dev/null
@@ -1,6 +0,0 @@
-[message-event.html]
-  type: testharness
-  [Properties of the 'message' event]
-    expected: FAIL
-    bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1164834
-