Bug 1590907 - Remove obsolete macro JS_NO_JSVAL_JSID_STRUCT_TYPES. r=sfink
authorPhilip Chimento <philip.chimento@gmail.com>
Tue, 12 Nov 2019 22:00:55 +0000
changeset 501682 41cd25e887f099990d5579ab417823c73fe244c6
parent 501681 b98e3a2058c06d33994a43e5637009fc910968eb
child 501683 35fb1e29016b0085ff06603a6ee1c54b023e6b86
push id114172
push userdluca@mozilla.com
push dateTue, 19 Nov 2019 11:31:10 +0000
treeherdermozilla-inbound@b5c5ba07d3db [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssfink
bugs1590907
milestone72.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1590907 - Remove obsolete macro JS_NO_JSVAL_JSID_STRUCT_TYPES. r=sfink This macro is defined when building the Rust bindings, but it doesn't actually affect anything. Differential Revision: https://phabricator.services.mozilla.com/D51771
js/rust/CMakeLists.txt
js/src/js-config.h.in
--- a/js/rust/CMakeLists.txt
+++ b/js/rust/CMakeLists.txt
@@ -21,15 +21,15 @@ if(MSVC)
 else()
   if(NOT "$ENV{CARGO_FEATURE_DEBUGMOZJS}" STREQUAL "")
     add_definitions(-g -O0 -DDEBUG -D_DEBUG)
   endif()
   if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
     add_definitions(-Wno-c++0x-extensions -Wno-return-type-c-linkage -Wno-invalid-offsetof)
   endif()
   add_definitions(-fPIC -fno-rtti)
-  add_definitions(-std=c++14 -DJS_NO_JSVAL_JSID_STRUCT_TYPES)
+  add_definitions(-std=c++14)
   add_definitions(-include $ENV{DEP_MOZJS_OUTDIR}/js/src/js-confdefs.h)
 endif()
 
 add_library(jsglue STATIC ${SOURCES})
 install(TARGETS jsglue ARCHIVE DESTINATION lib)
 
--- a/js/src/js-config.h.in
+++ b/js/src/js-config.h.in
@@ -24,19 +24,16 @@
 #  error "SpiderMonkey was configured with --enable-debug, so DEBUG must be defined when including this header"
 # endif
 #else
 # if defined(DEBUG) && !defined(RUST_BINDGEN)
 #  error "SpiderMonkey was configured with --disable-debug, so DEBUG must be not defined when including this header"
 # endif
 #endif
 
-/* Define to 1 if SpiderMonkey should not use struct types in debug builds. */
-#undef JS_NO_JSVAL_JSID_STRUCT_TYPES
-
 /* Define to 1 if SpiderMonkey should support multi-threaded clients.  */
 #undef JS_THREADSAFE
 
 /* Define to 1 if SpiderMonkey should include ctypes support.  */
 #undef JS_HAS_CTYPES
 
 /* Define to 1 if SpiderMonkey should support the ability to perform
    entirely too much GC.  */