Bug 1275297 - Create Visual Studio project files by default on Windows; r=glandium
☠☠ backed out by 836ded5dd332 ☠ ☠
authorGregory Szorc <gps@mozilla.com>
Tue, 24 May 2016 08:47:24 -0700
changeset 298798 408319d87eacb28848efeab0346eb815440adade
parent 298797 b0fac0d672e28bf5fe3e16c5fab6e3541c0cbff7
child 298799 1253710274373ffe0928ea7378ef2a60921d84a7
push id77319
push usergszorc@mozilla.com
push dateTue, 24 May 2016 22:47:45 +0000
treeherdermozilla-inbound@408319d87eac [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersglandium
bugs1275297
milestone49.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1275297 - Create Visual Studio project files by default on Windows; r=glandium Now that the VisualStudio backend will no-op if nothing has changed, it should be safe to always run this backend. On first run, backend generation takes ~3.5s on my machine. On subsequent run, it takes ~1.5s. Wall time for a no-op config.status is now ~15.7s. We could like make the Visual Studio backend faster by not writing so many project files. But this would require consolidating libraries in moz.build files. And that's out of scope for this change. MozReview-Commit-ID: 5W38HMGmcuV
moz.configure
--- a/moz.configure
+++ b/moz.configure
@@ -72,22 +72,24 @@ include(memory_include)
 @imports(_from='mozbuild.backend', _import='backends')
 def build_backends_choices(help):
     return tuple(backends)
 
 
 option('--enable-build-backend', nargs='+', choices=build_backends_choices,
        help='Enable additional build backends')
 
-@depends('--enable-build-backend', '--enable-artifact-builds')
-def build_backend(backends, artifact_builds):
+@depends('--enable-build-backend', '--enable-artifact-builds', target)
+def build_backend(backends, artifact_builds, target):
     if artifact_builds:
         all_backends = ['FasterMake+RecursiveMake']
     else:
         all_backends = ['RecursiveMake', 'FasterMake']
+    if target.os == 'WINNT':
+        all_backends.append('VisualStudio')
     all_backends.extend(backends)
     return unique_list(all_backends)
 
 set_config('BUILD_BACKENDS', build_backend)
 
 
 # Awk detection
 # ==============================================================