Bug 1336712 - netwerk: Drop test checks for Windows XP. r=RyanVM
authorChris Peterson <cpeterson@mozilla.com>
Thu, 13 Sep 2018 21:41:24 -0700
changeset 437841 3e815f61a1fc2cbecef147f9b2377b043b8eb4ee
parent 437840 406a83114d6c3279c005357894f0881fb65e650c
child 437842 5313921e7dee83ab65f358b723f4228b46937686
push id108171
push usercpeterson@mozilla.com
push dateMon, 24 Sep 2018 05:42:27 +0000
treeherdermozilla-inbound@5313921e7dee [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersRyanVM
bugs1336712
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1336712 - netwerk: Drop test checks for Windows XP. r=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D6584
netwerk/test/unit/test_udp_multicast.js
--- a/netwerk/test/unit/test_udp_multicast.js
+++ b/netwerk/test/unit/test_udp_multicast.js
@@ -11,17 +11,16 @@ const ADDRESS_TEST1 = "224.0.0.200";
 const ADDRESS_TEST2 = "224.0.0.201";
 const ADDRESS_TEST3 = "224.0.0.202";
 const ADDRESS_TEST4 = "224.0.0.203";
 
 const TIMEOUT = 2000;
 
 const ua = Cc["@mozilla.org/network/protocol;1?name=http"]
            .getService(Ci.nsIHttpProtocolHandler).userAgent;
-const isWinXP = ua.includes("Windows NT 5.1");
 
 var gConverter;
 
 function run_test() {
   setup();
   run_next_test();
 }
 
@@ -80,32 +79,27 @@ add_test(() => {
   let socket = createSocketAndJoin(ADDRESS_TEST2);
   socket.multicastLoopback = false;
   sendPing(socket, ADDRESS_TEST2).then(
     () => do_throw("Loopback disabled, but still got a packet"),
     run_next_test
   );
 });
 
-// The following multicast interface test doesn't work on Windows XP, as it
-// appears to allow packets no matter what address is given, so we'll skip the
-// test there.
-if (!isWinXP) {
-  add_test(() => {
-    info("Changing multicast interface");
-    let socket = createSocketAndJoin(ADDRESS_TEST3);
-    socket.multicastInterface = "127.0.0.1";
-    sendPing(socket, ADDRESS_TEST3).then(
-      () => do_throw("Changed interface, but still got a packet"),
-      run_next_test
-    );
-  });
+add_test(() => {
+  info("Changing multicast interface");
+  let socket = createSocketAndJoin(ADDRESS_TEST3);
+  socket.multicastInterface = "127.0.0.1";
+  sendPing(socket, ADDRESS_TEST3).then(
+    () => do_throw("Changed interface, but still got a packet"),
+    run_next_test
+  );
+});
 
 add_test(() => {
   info("Leaving multicast group");
   let socket = createSocketAndJoin(ADDRESS_TEST4);
   socket.leaveMulticast(ADDRESS_TEST4);
   sendPing(socket, ADDRESS_TEST4).then(
     () => do_throw("Left group, but still got a packet"),
     run_next_test
   );
 });
-}