Bug 1596982 - remove functools32 from the list of explicitly specified pip packages in python.py r=gbrown
authorEdwin Takahashi <egao@mozilla.com>
Sat, 16 Nov 2019 07:11:56 +0000
changeset 502312 3e4d6ff8aa5e8c719453d5f3a2b1e67a333f7b5a
parent 502311 1d6c106c86d52e7e6552f9fc73f5d349c1db529f
child 502313 7a28e398b881cca9b105fff733bf72205ec5782f
push id114172
push userdluca@mozilla.com
push dateTue, 19 Nov 2019 11:31:10 +0000
treeherdermozilla-inbound@b5c5ba07d3db [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgbrown
bugs1596982
milestone72.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1596982 - remove functools32 from the list of explicitly specified pip packages in python.py r=gbrown Changes: Do not explicitly specify `functools32` for installation, since pip is good at resolving dependencies. Differential Revision: https://phabricator.services.mozilla.com/D53309
testing/mozharness/mozharness/base/python.py
--- a/testing/mozharness/mozharness/base/python.py
+++ b/testing/mozharness/mozharness/base/python.py
@@ -491,22 +491,16 @@ class ResourceMonitoringMixin(Perfherder
         super(ResourceMonitoringMixin, self).__init__(*args, **kwargs)
 
         self.register_virtualenv_module('psutil>=3.1.1', method='pip',
                                         optional=True)
         self.register_virtualenv_module('mozsystemmonitor==0.4',
                                         method='pip', optional=True)
         self.register_virtualenv_module('jsonschema==2.5.1',
                                         method='pip')
-        # explicitly install functools32, because some slaves aren't using
-        # a version of pip recent enough to install it automatically with
-        # jsonschema (which depends on it)
-        # https://github.com/Julian/jsonschema/issues/233
-        self.register_virtualenv_module('functools32==3.2.3-2',
-                                        method='pip')
         self._resource_monitor = None
 
         # 2-tuple of (name, options) to assign Perfherder resource monitor
         # metrics to. This needs to be assigned by a script in order for
         # Perfherder metrics to be reported.
         self.resource_monitor_perfherder_id = None
 
     @PostScriptAction('create-virtualenv')