Backed out changeset e28fa79bc2f9 (bug 1501196) for suspicion of causing Bug 1503757. a=backout
authorMargareta Eliza Balazs <ebalazs@mozilla.com>
Thu, 01 Nov 2018 11:22:11 +0200
changeset 443905 3cff4bff1c9d8e65e73a966fe09c4e5aa1ed734a
parent 443904 dcc2391cc0dd480b95b4d669184ee4c2fd252a5d
child 443906 3a81ecf22e6fe82dc808fb986e559e9222134386
child 443960 c2149397b7b5b0432553dbc66747659af2b4fa91
child 444012 a0aeeebfeb681cfbd36250cb4477252d34cddc2c
push id109471
push userebalazs@mozilla.com
push dateThu, 01 Nov 2018 09:46:37 +0000
treeherdermozilla-inbound@3a81ecf22e6f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbackout
bugs1501196, 1503757
milestone65.0a1
backs oute28fa79bc2f94ca3b72456b47353f2e2dda8da1a
first release with
nightly linux32
3cff4bff1c9d / 65.0a1 / 20181101100640 / files
nightly linux64
3cff4bff1c9d / 65.0a1 / 20181101100640 / files
nightly mac
3cff4bff1c9d / 65.0a1 / 20181101100640 / files
nightly win32
3cff4bff1c9d / 65.0a1 / 20181101100640 / files
nightly win64
3cff4bff1c9d / 65.0a1 / 20181101100640 / files
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
releases
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset e28fa79bc2f9 (bug 1501196) for suspicion of causing Bug 1503757. a=backout
dom/workers/RuntimeService.cpp
--- a/dom/workers/RuntimeService.cpp
+++ b/dom/workers/RuntimeService.cpp
@@ -2021,20 +2021,16 @@ RuntimeService::CrashIfHanging()
 
 // This spins the event loop until all workers are finished and their threads
 // have been joined.
 void
 RuntimeService::Cleanup()
 {
   AssertIsOnMainThread();
 
-  if (!mShuttingDown) {
-    Shutdown();
-  }
-
   nsCOMPtr<nsIObserverService> obs = services::GetObserverService();
   NS_WARNING_ASSERTION(obs, "Failed to get observer service?!");
 
   if (mIdleThreadTimer) {
     if (NS_FAILED(mIdleThreadTimer->Cancel())) {
       NS_WARNING("Failed to cancel idle timer!");
     }
     mIdleThreadTimer = nullptr;