Bug 1446471 - Remove unused --stop argument from `mach python-test`; r=nalexander
authorGregory Szorc <gps@mozilla.com>
Tue, 06 Mar 2018 19:04:04 -0800
changeset 408623 3ccd4874096388a7fb9fc461048949fa449dda21
parent 408622 a31b00db0ca72375f2d64a4729031b0529f986fc
child 408624 3f506f2b60f0074da9664dd22eec443dff51a8fe
push id100996
push userbtara@mozilla.com
push dateSat, 17 Mar 2018 10:37:43 +0000
treeherdermozilla-inbound@97160a734959 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnalexander
bugs1446471
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1446471 - Remove unused --stop argument from `mach python-test`; r=nalexander This argument does nothing. While that's arguably a bug, I have no desire to fix it. So remove dead code. MozReview-Commit-ID: 9tToF66I7HE
python/mach_commands.py
--- a/python/mach_commands.py
+++ b/python/mach_commands.py
@@ -61,20 +61,16 @@ class MachCommands(MachCommandBase):
                                 append_env=append_env)
 
     @Command('python-test', category='testing',
              description='Run Python unit tests with an appropriate test runner.')
     @CommandArgument('-v', '--verbose',
                      default=False,
                      action='store_true',
                      help='Verbose output.')
-    @CommandArgument('--stop',
-                     default=False,
-                     action='store_true',
-                     help='Stop running tests after the first error or failure.')
     @CommandArgument('-j', '--jobs',
                      default=1,
                      type=int,
                      help='Number of concurrent jobs to run. Default is 1.')
     @CommandArgument('--subsuite',
                      default=None,
                      help=('Python subsuite to run. If not specified, all subsuites are run. '
                            'Use the string `default` to only run tests without a subsuite.'))
@@ -90,17 +86,16 @@ class MachCommands(MachCommandBase):
             import mozfile
             mozfile.remove(tempdir)
 
     def run_python_tests(self,
                          tests=[],
                          test_objects=None,
                          subsuite=None,
                          verbose=False,
-                         stop=False,
                          jobs=1,
                          **kwargs):
         self._activate_virtualenv()
 
         # Python's unittest, and in particular discover, has problems with
         # clashing namespaces when importing multiple test modules. What follows
         # is a simple way to keep environments separate, at the price of
         # launching Python multiple times. Most tests are run via mozunit,