Bug 1096014 - Regression: Unable to complete downloads in Firefox for Android. r=mfinkle
authorPaolo Amadini <paolo.mozmail@amadzone.org>
Thu, 13 Nov 2014 11:16:04 +0000
changeset 215606 3c84bb853ee6d45cff6c1dbe68b7723381acd5c2
parent 215605 430ab4980697124d8b6ec02f570e35e0cde64b1a
child 215607 7a19f76e912e0b8048a3192f0dc00397ab2abb9b
push id51796
push userryanvm@gmail.com
push dateThu, 13 Nov 2014 20:47:14 +0000
treeherdermozilla-inbound@a05b5362429f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmfinkle
bugs1096014
milestone36.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1096014 - Regression: Unable to complete downloads in Firefox for Android. r=mfinkle
toolkit/components/downloads/nsDownloadManager.cpp
--- a/toolkit/components/downloads/nsDownloadManager.cpp
+++ b/toolkit/components/downloads/nsDownloadManager.cpp
@@ -3357,19 +3357,19 @@ nsDownload::FixTargetPermissions()
 
   // Set perms according to umask.
   nsCOMPtr<nsIPropertyBag2> infoService =
       do_GetService("@mozilla.org/system-info;1");
   uint32_t gUserUmask = 0;
   rv = infoService->GetPropertyAsUint32(NS_LITERAL_STRING("umask"),
                                         &gUserUmask);
   if (NS_SUCCEEDED(rv)) {
-    rv = target->SetPermissions(0666 & ~gUserUmask);
+    (void)target->SetPermissions(0666 & ~gUserUmask);
   }
-  return rv;
+  return NS_OK;
 }
 
 nsresult
 nsDownload::MoveTempToTarget()
 {
   nsCOMPtr<nsIFile> target;
   nsresult rv = GetTargetFile(getter_AddRefs(target));
   NS_ENSURE_SUCCESS(rv, rv);