Remove the workaround added in bug 1022420 now that clang-cl understands __declspec(novtable)
authorEhsan Akhgari <ehsan@mozilla.com>
Fri, 05 Feb 2016 21:38:04 -0500
changeset 283344 3ba0bf1011206023969443c1c4a65dbb0a996f99
parent 283343 4892358dbf20a8568090837d3f3a14d112c3829b
child 283345 f9649610cd9ce5d145a7de1e0a091381222ed570
push id71504
push usereakhgari@mozilla.com
push dateSat, 06 Feb 2016 21:58:04 +0000
treeherdermozilla-inbound@3ba0bf101120 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1022420
milestone47.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Remove the workaround added in bug 1022420 now that clang-cl understands __declspec(novtable)
xpcom/base/nscore.h
--- a/xpcom/base/nscore.h
+++ b/xpcom/base/nscore.h
@@ -243,17 +243,17 @@
  * xpidl can determine that the interface can't contain a constructor.
  * This results in some space savings and possible runtime savings -
  * see bug 49416.  We undefine it first, as xpidl-generated headers
  * define it for IDL uses that don't include this file.
  */
 #ifdef NS_NO_VTABLE
 #undef NS_NO_VTABLE
 #endif
-#if defined(_MSC_VER) && !defined(__clang__)
+#if defined(_MSC_VER)
 #define NS_NO_VTABLE __declspec(novtable)
 #else
 #define NS_NO_VTABLE
 #endif
 
 
 /**
  * Generic XPCOM result data type