Bug 1571110 - Change chrome_settings_overrides.search_provider.favicon_url from "url" to "relativeUrl" r=Standard8
authorMyeongjun Go <myeongjun.ko@gmail.com>
Fri, 15 Nov 2019 16:30:08 +0000
changeset 502220 3a763059a684969df0246d673943ec1d5ff8996b
parent 502219 dbc1778c0ebdfa4908d66c2c700daa798bd68209
child 502221 5975264fd34b299dc88a467863a139b46c173a09
push id114172
push userdluca@mozilla.com
push dateTue, 19 Nov 2019 11:31:10 +0000
treeherdermozilla-inbound@b5c5ba07d3db [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersStandard8
bugs1571110
milestone72.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1571110 - Change chrome_settings_overrides.search_provider.favicon_url from "url" to "relativeUrl" r=Standard8 Differential Revision: https://phabricator.services.mozilla.com/D52782
browser/components/extensions/schemas/chrome_settings_overrides.json
browser/components/extensions/test/browser/browser_ext_search_favicon.js
--- a/browser/components/extensions/schemas/chrome_settings_overrides.json
+++ b/browser/components/extensions/schemas/chrome_settings_overrides.json
@@ -34,17 +34,17 @@
                     "type": "string",
                     "format": "url",
                     "pattern": "^https://.*$",
                     "preprocess": "localize"
                   },
                   "favicon_url": {
                     "type": "string",
                     "optional": true,
-                    "format": "url",
+                    "format": "relativeUrl",
                     "preprocess": "localize"
                   },
                   "suggest_url": {
                     "type": "string",
                     "optional": true,
                     "pattern": "^https://.*$|^$",
                     "preprocess": "localize"
                   },
--- a/browser/components/extensions/test/browser/browser_ext_search_favicon.js
+++ b/browser/components/extensions/test/browser/browser_ext_search_favicon.js
@@ -29,23 +29,21 @@ function promiseEngineIconLoaded(engineN
       );
     }
   );
 }
 
 add_task(async function test_search_favicon() {
   let searchExt = ExtensionTestUtils.loadExtension({
     manifest: {
-      icons: {
-        16: "someFavicon.png",
-      },
       chrome_settings_overrides: {
         search_provider: {
           name: "Engine Only",
           search_url: "https://example.com/",
+          favicon_url: "someFavicon.png",
         },
       },
     },
     files: {
       "someFavicon.png": atob(FAKE_ICON_DATA),
     },
     useAddonManager: "temporary",
   });
@@ -74,23 +72,21 @@ add_task(async function test_search_favi
       },
     },
     useAddonManager: "temporary",
   });
 
   let extension = ExtensionTestUtils.loadExtension({
     manifest: {
       permissions: ["search"],
-      icons: {
-        16: "myFavicon.png",
-      },
       chrome_settings_overrides: {
         search_provider: {
           name: "My Engine",
           search_url: "https://example.org/",
+          favicon_url: "myFavicon.png",
         },
       },
     },
     files: {
       "myFavicon.png": imageBuffer,
     },
     useAddonManager: "temporary",
     async background() {