Backed out 2 changesets (bug 1360992, bug 1361654) for a 70% failure rate in test_fileReader.html on ASan e10s
authorPhil Ringnalda <philringnalda@gmail.com>
Fri, 05 May 2017 12:35:57 -0700
changeset 356784 379b03af76d417ba5998a2fb13b125602540c8cc
parent 356783 6b0f7ac46e1f81cd72931aaee41f4863d8d8876d
child 356785 91e80fe926250b6d2ce64cc955dc194bcaae0b3a
push id89963
push userphilringnalda@gmail.com
push dateFri, 05 May 2017 19:36:06 +0000
treeherdermozilla-inbound@379b03af76d4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1360992, 1361654
milestone55.0a1
backs outab9fdee3a6a471fd88db5790e8499bdb92a4de58
141c2dfd49ff3b0f2bde1daf2605c2af857b6f01
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out 2 changesets (bug 1360992, bug 1361654) for a 70% failure rate in test_fileReader.html on ASan e10s Backed out changeset ab9fdee3a6a4 (bug 1360992) Backed out changeset 141c2dfd49ff (bug 1361654) MozReview-Commit-ID: 3rSzvmc5FPx
dom/file/ipc/IPCBlobInputStreamChild.cpp
xpcom/io/SlicedInputStream.cpp
--- a/dom/file/ipc/IPCBlobInputStreamChild.cpp
+++ b/dom/file/ipc/IPCBlobInputStreamChild.cpp
@@ -162,17 +162,16 @@ IPCBlobInputStreamChild::StreamNeeded(IP
 
   RefPtr<StreamNeededRunnable> runnable = new StreamNeededRunnable(this);
   mOwningThread->Dispatch(runnable, NS_DISPATCH_NORMAL);
 }
 
 mozilla::ipc::IPCResult
 IPCBlobInputStreamChild::RecvStreamReady(const OptionalIPCStream& aStream)
 {
-  MutexAutoLock lock(mMutex);
   MOZ_ASSERT(!mPendingOperations.IsEmpty());
 
   nsCOMPtr<nsIInputStream> stream = DeserializeIPCStream(aStream);
 
   RefPtr<StreamReadyRunnable> runnable =
     new StreamReadyRunnable(mPendingOperations[0].mStream, stream);
   mPendingOperations[0].mEventTarget->Dispatch(runnable, NS_DISPATCH_NORMAL);
 
--- a/xpcom/io/SlicedInputStream.cpp
+++ b/xpcom/io/SlicedInputStream.cpp
@@ -33,34 +33,30 @@ SlicedInputStream::SlicedInputStream(nsI
   : mWeakCloneableInputStream(nullptr)
   , mWeakIPCSerializableInputStream(nullptr)
   , mWeakSeekableInputStream(nullptr)
   , mWeakAsyncInputStream(nullptr)
   , mStart(aStart)
   , mLength(aLength)
   , mCurPos(0)
   , mClosed(false)
-  , mAsyncWaitFlags(0)
-  , mAsyncWaitRequestedCount(0)
 {
   MOZ_ASSERT(aInputStream);
   SetSourceStream(aInputStream);
 }
 
 SlicedInputStream::SlicedInputStream()
   : mWeakCloneableInputStream(nullptr)
   , mWeakIPCSerializableInputStream(nullptr)
   , mWeakSeekableInputStream(nullptr)
   , mWeakAsyncInputStream(nullptr)
   , mStart(0)
   , mLength(0)
   , mCurPos(0)
   , mClosed(false)
-  , mAsyncWaitFlags(0)
-  , mAsyncWaitRequestedCount(0)
 {}
 
 SlicedInputStream::~SlicedInputStream()
 {}
 
 void
 SlicedInputStream::SetSourceStream(nsIInputStream* aInputStream)
 {