Bug 742434 - Part 1: Make ContentSecurityPolicy constructor explicit. r=gcp
☠☠ backed out by c71004cf2ebf ☠ ☠
authorJulian Hector <julian.r.hector@gmail.com>
Tue, 05 Jul 2016 03:07:00 +0200
changeset 303607 3601419d2e4b21fe407226d648d5389559f44a20
parent 303606 fb45e03a6c2e916025b177e4bf421ecaf05525a6
child 303608 730fcdccb26e389fa7bad04dfe5903eeb5796ea3
push id79131
push usergpascutto@mozilla.com
push dateTue, 05 Jul 2016 08:04:41 +0000
treeherdermozilla-inbound@7a504a73b6f2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgcp
bugs742434
milestone50.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 742434 - Part 1: Make ContentSecurityPolicy constructor explicit. r=gcp MozReview-Commit-ID: HrBpcQ1BYFI
security/sandbox/linux/SandboxFilter.cpp
--- a/security/sandbox/linux/SandboxFilter.cpp
+++ b/security/sandbox/linux/SandboxFilter.cpp
@@ -399,17 +399,17 @@ class ContentSandboxPolicy : public Sand
       return BlockedSyscallTrap(aArgs, nullptr);
     }
     return (flags & AT_SYMLINK_NOFOLLOW) == 0
       ? broker->Stat(path, buf)
       : broker->LStat(path, buf);
   }
 
 public:
-  ContentSandboxPolicy(SandboxBrokerClient* aBroker):mBroker(aBroker) { }
+  explicit ContentSandboxPolicy(SandboxBrokerClient* aBroker):mBroker(aBroker) { }
   virtual ~ContentSandboxPolicy() { }
   virtual ResultExpr PrctlPolicy() const override {
     // Ideally this should be restricted to a whitelist, but content
     // uses enough things that it's not trivial to determine it.
     return Allow();
   }
   virtual Maybe<ResultExpr> EvaluateSocketCall(int aCall) const override {
     switch(aCall) {