Bug 1251362 - Part 1 - Increase SwipeRefreshLayout weight. r=liuche
authorJan Henning <jh+bugzilla@buttercookie.de>
Mon, 16 May 2016 17:53:01 +0200
changeset 301154 35e71e69db49f4672512db7b26dc2ad517d7cf81
parent 301153 2011b521c19712830278bf7af43dae1034a14a7f
child 301155 3fe4b60dbcd0cd9f4ff567cec72dfd97fc1e7601
push id78241
push userkwierso@gmail.com
push dateThu, 09 Jun 2016 00:09:10 +0000
treeherdermozilla-inbound@2c66b75bbb7f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersliuche
bugs1251362, 1267884
milestone50.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1251362 - Part 1 - Increase SwipeRefreshLayout weight. r=liuche Otherwise, depending on the device's display dimensions, a second smart folder would be overlapped by the empty view message that is displayed when no history is present for the history panel to display. Once we've updated to a newer version of the support library (see bug 1267884), we should revisit this and see if using "wrap_content" is working properly instead. MozReview-Commit-ID: 1xBCeiST9n4
mobile/android/base/resources/layout/home_combined_history_panel.xml
--- a/mobile/android/base/resources/layout/home_combined_history_panel.xml
+++ b/mobile/android/base/resources/layout/home_combined_history_panel.xml
@@ -7,17 +7,17 @@
               android:layout_width="match_parent"
               android:layout_height="match_parent"
               android:orientation="vertical">
 
     <android.support.v4.widget.SwipeRefreshLayout
             android:id="@+id/refresh_layout"
             android:layout_width="match_parent"
             android:layout_height="0dp"
-            android:layout_weight="1">
+            android:layout_weight="1.2">
 
         <org.mozilla.gecko.home.CombinedHistoryRecyclerView
                 android:id="@+id/combined_recycler_view"
                 android:layout_width="match_parent"
                 android:layout_height="match_parent"
                 android:scrollbars="vertical"/>
 
     </android.support.v4.widget.SwipeRefreshLayout>