Bug 1563607 Part 1 - Service worker check evaluation runnable should be a debuggee runnable, r=asuth.
☠☠ backed out by f690fa2d0e1f ☠ ☠
authorBrian Hackett <bhackett1024@gmail.com>
Wed, 06 Nov 2019 18:26:17 +0000
changeset 500936 33e9b3eecd98dd808a50a21204cff4f954333cad
parent 500935 ad6956af9d33feddbf7b84049b08425c1ac371b6
child 500937 6d02ecfce856b46a71d1c0a2050f57c7736c81f8
push id114166
push userapavel@mozilla.com
push dateThu, 07 Nov 2019 10:04:01 +0000
treeherdermozilla-inbound@d271c572a9bc [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersasuth
bugs1563607
milestone72.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1563607 Part 1 - Service worker check evaluation runnable should be a debuggee runnable, r=asuth. Differential Revision: https://phabricator.services.mozilla.com/D47541
dom/serviceworkers/ServiceWorkerPrivate.cpp
--- a/dom/serviceworkers/ServiceWorkerPrivate.cpp
+++ b/dom/serviceworkers/ServiceWorkerPrivate.cpp
@@ -119,17 +119,17 @@ ServiceWorkerPrivate::~ServiceWorkerPriv
   MOZ_ASSERT(mSupportsArray.IsEmpty());
   MOZ_ASSERT(mIdlePromiseHolder.IsEmpty());
 
   mIdleWorkerTimer->Cancel();
 }
 
 namespace {
 
-class CheckScriptEvaluationWithCallback final : public WorkerRunnable {
+class CheckScriptEvaluationWithCallback final : public WorkerDebuggeeRunnable {
   nsMainThreadPtrHandle<ServiceWorkerPrivate> mServiceWorkerPrivate;
   nsMainThreadPtrHandle<KeepAliveToken> mKeepAliveToken;
 
   // The script evaluation result must be reported even if the runnable
   // is cancelled.
   RefPtr<LifeCycleEventCallback> mScriptEvaluationCallback;
 
 #ifdef DEBUG
@@ -137,17 +137,17 @@ class CheckScriptEvaluationWithCallback 
 #endif
 
  public:
   CheckScriptEvaluationWithCallback(
       WorkerPrivate* aWorkerPrivate,
       ServiceWorkerPrivate* aServiceWorkerPrivate,
       KeepAliveToken* aKeepAliveToken,
       LifeCycleEventCallback* aScriptEvaluationCallback)
-      : WorkerRunnable(aWorkerPrivate),
+      : WorkerDebuggeeRunnable(aWorkerPrivate, WorkerThreadModifyBusyCount),
         mServiceWorkerPrivate(new nsMainThreadPtrHolder<ServiceWorkerPrivate>(
             "CheckScriptEvaluationWithCallback::mServiceWorkerPrivate",
             aServiceWorkerPrivate)),
         mKeepAliveToken(new nsMainThreadPtrHolder<KeepAliveToken>(
             "CheckScriptEvaluationWithCallback::mKeepAliveToken",
             aKeepAliveToken)),
         mScriptEvaluationCallback(aScriptEvaluationCallback)
 #ifdef DEBUG