Bug 1593708 - Part 3: Remove inRDMPane attribute from Document. r=bradwerth,smaug
authorMicah Tigley <mtigley@mozilla.com>
Thu, 07 Nov 2019 22:17:25 +0000
changeset 502465 33d4fb0808c9f786038a318eb87ddcec3e69b97c
parent 502464 157248203e4a53a0f04055c7ee875eeb0c55f11c
child 502466 32913780ebb3fae5fce3499e90692332cde39578
push id114172
push userdluca@mozilla.com
push dateTue, 19 Nov 2019 11:31:10 +0000
treeherdermozilla-inbound@b5c5ba07d3db [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbradwerth, smaug
bugs1593708
milestone72.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1593708 - Part 3: Remove inRDMPane attribute from Document. r=bradwerth,smaug Depends on D52216 Differential Revision: https://phabricator.services.mozilla.com/D52217
dom/base/Document.cpp
dom/base/Document.h
dom/webidl/Document.webidl
--- a/dom/base/Document.cpp
+++ b/dom/base/Document.cpp
@@ -1348,17 +1348,16 @@ Document::Document(const char* aContentT
       mServoRestyleRootDirtyBits(0),
       mThrowOnDynamicMarkupInsertionCounter(0),
       mIgnoreOpensDuringUnloadCounter(0),
       mDocLWTheme(Doc_Theme_Uninitialized),
       mSavedResolution(1.0f),
       mPendingInitialTranslation(false),
       mGeneration(0),
       mCachedTabSizeGeneration(0),
-      mInRDMPane(false),
       mNextFormNumber(0),
       mNextControlNumber(0) {
   MOZ_LOG(gDocumentLeakPRLog, LogLevel::Debug, ("DOCUMENT %p created", this));
 
   SetIsInDocument();
   SetIsConnected(true);
 
   // Create these unconditionally, they will be used to warn about the `zoom`
--- a/dom/base/Document.h
+++ b/dom/base/Document.h
@@ -4172,19 +4172,16 @@ class Document : public nsINode,
   void MaybeInitializeFinalizeFrameLoaders();
 
   void SetDelayFrameLoaderInitialization(bool aDelayFrameLoaderInitialization) {
     mDelayFrameLoaderInitialization = aDelayFrameLoaderInitialization;
   }
 
   void SetPrototypeDocument(nsXULPrototypeDocument* aPrototype);
 
-  bool InRDMPane() const { return mInRDMPane; }
-  void SetInRDMPane(bool aInRDMPane) { mInRDMPane = aInRDMPane; }
-
   // Returns true if we use overlay scrollbars on the system wide or on the
   // given document.
   static bool UseOverlayScrollbars(const Document* aDocument);
 
   static bool HasRecentlyStartedForegroundLoads();
 
   static bool AutomaticStorageAccessCanBeGranted(nsIPrincipal* aPrincipal);
 
@@ -5337,18 +5334,16 @@ class Document : public nsINode,
 
   // Document generation. Gets incremented everytime it changes.
   int32_t mGeneration;
 
   // Cached TabSizes values for the document.
   int32_t mCachedTabSizeGeneration;
   nsTabSizes mCachedTabSizes;
 
-  bool mInRDMPane;
-
   // The principal to use for the storage area of this document.
   nsCOMPtr<nsIPrincipal> mIntrinsicStoragePrincipal;
 
   // The cached storage principal for this document.
   // This is mutable so that we can keep EffectiveStoragePrincipal() const
   // which is required due to its CloneDocHelper() call site.  :-(
   mutable nsCOMPtr<nsIPrincipal> mActiveStoragePrincipal;
 
--- a/dom/webidl/Document.webidl
+++ b/dom/webidl/Document.webidl
@@ -627,20 +627,16 @@ partial interface Document {
     [SameObject, Pref="dom.security.featurePolicy.webidl.enabled"]
     readonly attribute FeaturePolicy featurePolicy;
 };
 
 /**
  * Document extensions to support devtools.
  */
 partial interface Document {
-  // Is the Document embedded in a Responsive Design Mode pane. This property
-  // is not propegated to descendant Documents upon settting.
-  [ChromeOnly]
-  attribute boolean inRDMPane;
   // Extension to give chrome JS the ability to set the window screen
   // orientation while in RDM.
   [ChromeOnly]
   void setRDMPaneOrientation(OrientationType type, float rotationAngle);
 };
 
 // Extension to give chrome JS the ability to specify a non-default keypress
 // event model.