Bug 1576728 - Let blocklist entries for FYUnZIP and PuddingZip ride the trains but confine them to older/unversioned dlls. r=aklotz
authorphilipp <madperson@gmx.at>
Thu, 14 Nov 2019 23:40:00 +0000
changeset 502112 3322c8c93b02a7e848951a454a5c94f6d4704a74
parent 502111 409ebe45687765c849936626fbc7d95fcfc17f6d
child 502113 ff4ff0dd4da373d91ebf6b5f9a13782a69de7847
push id114172
push userdluca@mozilla.com
push dateTue, 19 Nov 2019 11:31:10 +0000
treeherdermozilla-inbound@b5c5ba07d3db [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersaklotz
bugs1576728
milestone72.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1576728 - Let blocklist entries for FYUnZIP and PuddingZip ride the trains but confine them to older/unversioned dlls. r=aklotz Differential Revision: https://phabricator.services.mozilla.com/D53103
mozglue/dllservices/WindowsDllBlocklistDefs.in
--- a/mozglue/dllservices/WindowsDllBlocklistDefs.in
+++ b/mozglue/dllservices/WindowsDllBlocklistDefs.in
@@ -216,20 +216,20 @@ ALL_PROCESSES += [
     # Ivanti Endpoint Security, bug 1553776
     DllBlocklistEntry("sxwmon.dll", ALL_VERSIONS),
     DllBlocklistEntry("sxwmon64.dll", ALL_VERSIONS),
 
     # 360 Safeguard/360 Total Security causes a11y crashes, bug 1536227.
     DllBlocklistEntry("safemon64.dll", ALL_VERSIONS),
 
     # FYunZip and PuddingZip cause crashes, bug 1576728
-    DllBlocklistEntry("oly64.dll", ALL_VERSIONS, condition='defined(NIGHTLY_BUILD)'),
-    DllBlocklistEntry("oly.dll", ALL_VERSIONS, condition='defined(NIGHTLY_BUILD)'),
-    DllBlocklistEntry("pdzipmenu64.dll", ALL_VERSIONS, condition='defined(NIGHTLY_BUILD)'),
-    DllBlocklistEntry("pdzipmenu32.dll", ALL_VERSIONS, condition='defined(NIGHTLY_BUILD)'),
+    DllBlocklistEntry("oly64.dll", (1, 1, 3, 19919)),
+    DllBlocklistEntry("oly.dll", (1, 1, 3, 19919)),
+    DllBlocklistEntry("pdzipmenu64.dll", UNVERSIONED),
+    DllBlocklistEntry("pdzipmenu32.dll", UNVERSIONED),
 
     # Old versions of Digital Guardian, bug 1318858
     DllBlocklistEntry("dgapi.dll", (7, 5, 0, 0xffff)),
     DllBlocklistEntry("dgapi64.dll", (7, 5, 0, 0xffff)),
 ]
 
 ALL_PROCESSES_TESTS += [
     # DLLs used by TestDllBlocklist* gTests