Fix for bug 799465 (Add complete support for non-nsISupports objects in new DOM bindings) - allow non-nsISupports object to be parents, take care of review comment. r=bz.
☠☠ backed out by 5540b310d435 ☠ ☠
authorPeter Van der Beken <peterv@propagandism.org>
Fri, 12 Oct 2012 14:52:32 +0200
changeset 110082 3044539fec87be189addde74159b93293c6301cb
parent 110081 78918f4eb983d826174ad77d8b223540e310ac0e
child 110083 31bebe4cdeede3e717a021aef7c0007389bec00f
push id16347
push userpvanderbeken@mozilla.com
push dateFri, 12 Oct 2012 13:01:23 +0000
treeherdermozilla-inbound@3044539fec87 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbz
bugs799465
milestone19.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Fix for bug 799465 (Add complete support for non-nsISupports objects in new DOM bindings) - allow non-nsISupports object to be parents, take care of review comment. r=bz.
dom/bindings/BindingUtils.h
--- a/dom/bindings/BindingUtils.h
+++ b/dom/bindings/BindingUtils.h
@@ -630,18 +630,18 @@ struct ParentObject {
 
 inline nsWrapperCache*
 GetWrapperCache(const ParentObject& aParentObject)
 {
   return aParentObject.mWrapperCache;
 }
 
 template<class T>
-inline T
-GetParentPointer(T aObject)
+inline T*
+GetParentPointer(T* aObject)
 {
   return aObject;
 }
 
 inline nsISupports*
 GetParentPointer(const ParentObject& aObject)
 {
   return aObject.mObject;