Bug 1591007 - Save Changes in Manage Data dialog in preferences doesn't close the dialog, r=Gijs
authorJaStenson <jacob@nosnets.co.uk>
Thu, 14 Nov 2019 15:30:27 +0000
changeset 501967 2eaeb35d81d6ff8aff7b3944a5bfe7dd5693dac7
parent 501966 e727898953edb7c1b536cace1e7add0a7de2a536
child 501968 6e3d285d14eeffbf8861d39c664b796bd9640322
push id114172
push userdluca@mozilla.com
push dateTue, 19 Nov 2019 11:31:10 +0000
treeherdermozilla-inbound@b5c5ba07d3db [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersGijs
bugs1591007
milestone72.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1591007 - Save Changes in Manage Data dialog in preferences doesn't close the dialog, r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D53020
browser/components/preferences/siteDataSettings.js
--- a/browser/components/preferences/siteDataSettings.js
+++ b/browser/components/preferences/siteDataSettings.js
@@ -277,16 +277,18 @@ let gSiteDataSettings = {
         if (allowed) {
           try {
             await SiteDataManager.remove(removals);
           } catch (e) {
             Cu.reportError(e);
           }
         }
       }
+    } else {
+      allowed = true;
     }
 
     // If the user cancelled the confirm dialog keep the site data window open,
     // they can still press cancel again to exit.
     if (allowed) {
       this.close();
     }
   },