Bug 1392787 - Add a linter to prevent comment-disabling tests in manifestparser manifests, r=jmaher
☠☠ backed out by c1fdb1c43538 ☠ ☠
authorAndrew Halberstadt <ahalberstadt@mozilla.com>
Wed, 23 Aug 2017 09:33:18 -0400
changeset 376714 2ce8a387fa80ac5ba6781505f206dd8de4cd217f
parent 376713 bf5a6ff97a8f55899d11610b4046e7fbe6bd3bc6
child 376715 e774700fe07014aa47e62d8de0240855ba69c255
push id94144
push userryanvm@gmail.com
push dateFri, 25 Aug 2017 00:21:50 +0000
treeherdermozilla-inbound@942d868646cf [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjmaher
bugs1392787
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1392787 - Add a linter to prevent comment-disabling tests in manifestparser manifests, r=jmaher MozReview-Commit-ID: LG47ASBMA17
taskcluster/ci/source-test/mozlint.yml
tools/lint/test-disable.yml
--- a/taskcluster/ci/source-test/mozlint.yml
+++ b/taskcluster/ci/source-test/mozlint.yml
@@ -52,16 +52,36 @@ mozlint-flake8:
         mach: lint -l flake8 -f treeherder
     when:
         files-changed:
             - '**/*.py'
             - '**/.flake8'
             - 'python/mozlint/**'
             - 'tools/lint/**'
 
+mozlint-test-manifest:
+    description: lint test manifests
+    platform: lint/opt
+    treeherder:
+        symbol: tm
+        kind: test
+        tier: 1
+    worker-type: aws-provisioner-v1/gecko-t-linux-xlarge
+    worker:
+        docker-image: {in-tree: "lint"}
+        max-run-time: 1800
+    run:
+        using: mach
+        mach: lint -l test-disable -f treeherder
+    when:
+        files-changed:
+            - '**/*.ini'
+            - 'python/mozlint/**'
+            - 'tools/lint/**'
+
 mozlint-yaml:
     description: yamllint run over the gecko codebase
     platform: lint/opt
     treeherder:
         symbol: yaml
         kind: test
         tier: 1
     worker-type: aws-provisioner-v1/gecko-t-linux-xlarge
new file mode 100644
--- /dev/null
+++ b/tools/lint/test-disable.yml
@@ -0,0 +1,14 @@
+---
+no-comment-disable:
+    description: "Use 'disable=<reason>' to disable a test instead of a comment"
+    include:
+        - "**/*.ini"
+    exclude:
+        - "**/application.ini"
+        - "**/l10n.ini"
+        - testing/mozbase/manifestparser/tests
+        - testing/web-platform
+        - xpcom/tests/unit/data
+    extensions: ['ini']
+    type: regex
+    payload: ^[ \t]*(#|;)[ \t]*\[