Bug 1593170. Skip 1553571-1.html reftest on android debug webrender. r=mattwoodrow
☠☠ backed out by bdca724cf3a2 ☠ ☠
authorTimothy Nikkel <tnikkel@gmail.com>
Mon, 18 Nov 2019 00:50:47 +0000
changeset 502366 2c8e57a90cb8dbe3763a6d26de0198aba1bcb75e
parent 502365 d511975b764e8f5e97c4511dc39c9aa103e30793
child 502367 39d63ae4d2871837382c0cbfe8ba616f60ed116c
push id114172
push userdluca@mozilla.com
push dateTue, 19 Nov 2019 11:31:10 +0000
treeherdermozilla-inbound@b5c5ba07d3db [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmattwoodrow
bugs1593170, 1553571
milestone72.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1593170. Skip 1553571-1.html reftest on android debug webrender. r=mattwoodrow The changes to make the test harness avoid busy waiting with setTimeout(0)'s made this test fail on Android 8.0 debug webrender. In order to get an active layer the test tweaks a transform slightly that has no visual effect every 74 ms. This is necessary to test the bug as far as I can tell (I wrote the test). The test times out because MakeProgress never makes any progress, there is always an afterpaint pending or an after paint has fired and we need to update the canvas for it. The painting and running through the settimeouts etc of the reftest harness take slightly too long. Before the changes to remove the busy waits we were just barely passing this test, it took 76 seconds in once instance that I checked and hundreds of iterations before we could make progress. Haven't debugged exactly why removing the busywaits makes this fail but it doesn't seem important. Differential Revision: https://phabricator.services.mozilla.com/D52650
layout/reftests/bugs/reftest.list
--- a/layout/reftests/bugs/reftest.list
+++ b/layout/reftests/bugs/reftest.list
@@ -2071,17 +2071,17 @@ fuzzy-if(winWidget&&!webrender,0-89,0-14
 fuzzy-if(!webrender,1-5,66-547) fuzzy-if(geckoview&&!webrender,1-2,64-141) == 1529992-1.html 1529992-1-ref.html
 fuzzy-if(!webrender,0-6,0-34) fuzzy-if(Android,9-14,44-60) fails-if(webrender) == 1529992-2.html 1529992-2-ref.html
 == 1535040-1.html 1535040-1-ref.html
 == 1545360-1.xhtml 1545360-1-ref.xhtml
 skip-if(!asyncPan) == 1544895.html 1544895-ref.html
 == 1547759-1.html 1547759-1-ref.html
 == 1548809.html 1548809-ref.html
 != 1552789-1.html 1552789-ref-1.html
-pref(image.downscale-during-decode.enabled,true) == 1553571-1.html 1553571-1-ref.html
+pref(image.downscale-during-decode.enabled,true) skip-if(Android&&webrender) == 1553571-1.html 1553571-1-ref.html
 == 1558937-1.html 1558937-1-ref.html
 != 1563484.html 1563484-notref.html
 == 1563484.html 1563484-ref.html
 fuzzy-if(!webrender||!winWidget,251-255,464-1613) fuzzy-if(webrender&&winWidget,255-255,6-6) fuzzy-if(geckoview&&webrender,251-255,1392-1401) == 1562733-rotated-nastaliq-1.html 1562733-rotated-nastaliq-1-ref.html
 fuzzy-if(winWidget&&webrender,0-31,0-3) fuzzy-if(geckoview&&webrender,0-93,0-87) == 1562733-rotated-nastaliq-2.html 1562733-rotated-nastaliq-2-ref.html
 test-pref(plain_text.wrap_long_lines,false) != 1565129.txt 1565129.txt
 fuzzy(0-32,0-8) fuzzy-if(Android&&webrender,0-32,0-1458) == 1576553-1.html 1576553-1-ref.html
 fuzzy(0-1,0-10000) == 1577566-1.html 1577566-1-ref.html