Bug 1276400 part 2. Stop setting the dontReportUncaught option on the worker JSContext, since workers should be using AutoJSAPI/AutoEntryScript for everything. r=bkelly
authorBoris Zbarsky <bzbarsky@mit.edu>
Tue, 31 May 2016 22:01:30 -0400
changeset 299836 2c74e35ddd1e8a46e04741caa7608ea784369ba1
parent 299835 5ae227cd2b5d1aebb1ca866694b5ba0be242327c
child 299837 2abd1b50f67314aee593ef3d629505492b55d832
push id77709
push userbzbarsky@mozilla.com
push dateWed, 01 Jun 2016 02:04:55 +0000
treeherdermozilla-inbound@7d46836853cd [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbkelly
bugs1276400
milestone49.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1276400 part 2. Stop setting the dontReportUncaught option on the worker JSContext, since workers should be using AutoJSAPI/AutoEntryScript for everything. r=bkelly
dom/workers/RuntimeService.cpp
--- a/dom/workers/RuntimeService.cpp
+++ b/dom/workers/RuntimeService.cpp
@@ -142,19 +142,16 @@ static_assert(MAX_WORKERS_PER_DOMAIN >= 
 #define PREF_WORKERS_OPTIONS_PREFIX PREF_WORKERS_PREFIX "options."
 #define PREF_MEM_OPTIONS_PREFIX "mem."
 #define PREF_GCZEAL "gcZeal"
 
 namespace {
 
 const uint32_t kNoIndex = uint32_t(-1);
 
-const JS::ContextOptions kRequiredContextOptions =
-  JS::ContextOptions().setDontReportUncaught(true);
-
 uint32_t gMaxWorkersPerDomain = MAX_WORKERS_PER_DOMAIN;
 
 // Does not hold an owning reference.
 RuntimeService* gRuntimeService = nullptr;
 
 // Only true during the call to Init.
 bool gRuntimeServiceDuringInit = false;
 
@@ -802,18 +799,16 @@ CreateJSContextForWorker(WorkerPrivate* 
     NS_WARNING("Could not create new context!");
     return nullptr;
   }
 
   JS_SetInterruptCallback(aRuntime, InterruptCallback);
 
   js::SetCTypesActivityCallback(aRuntime, CTypesActivityCallback);
 
-  JS::ContextOptionsRef(workerCx) = kRequiredContextOptions;
-
 #ifdef JS_GC_ZEAL
   JS_SetGCZeal(workerCx, settings.gcZeal, settings.gcZealFrequency);
 #endif
 
   return workerCx;
 }
 
 static bool