Bug 1276400 part 3. Stop setting the dontReportUncaught option in IPC code, since we're working with an AutoJSAPI there. r=bkelly
authorBoris Zbarsky <bzbarsky@mit.edu>
Tue, 31 May 2016 22:04:33 -0400
changeset 299837 2abd1b50f67314aee593ef3d629505492b55d832
parent 299836 2c74e35ddd1e8a46e04741caa7608ea784369ba1
child 299838 7d46836853cd3bc69986f012bcc9466a8c00853a
push id77709
push userbzbarsky@mozilla.com
push dateWed, 01 Jun 2016 02:04:55 +0000
treeherdermozilla-inbound@7d46836853cd [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbkelly
bugs1276400
milestone49.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1276400 part 3. Stop setting the dontReportUncaught option in IPC code, since we're working with an AutoJSAPI there. r=bkelly
js/ipc/WrapperAnswer.cpp
--- a/js/ipc/WrapperAnswer.cpp
+++ b/js/ipc/WrapperAnswer.cpp
@@ -405,19 +405,17 @@ WrapperAnswer::RecvCallOrConstruct(const
                 return fail(aes, rs);
             if (!vals.append(v))
                 return fail(aes, rs);
         }
     }
 
     RootedValue rval(cx);
     {
-        AutoSaveContextOptions asco(cx);
-        ContextOptionsRef(cx).setDontReportUncaught(true);
-
+        MOZ_ASSERT(JS::ContextOptionsRef(cx).autoJSAPIOwnsErrorReporting());
         HandleValueArray args = HandleValueArray::subarray(vals, 2, vals.length() - 2);
         if (construct) {
             RootedObject obj(cx);
             if (!JS::Construct(cx, vals[0], args, &obj))
                 return fail(aes, rs);
             rval.setObject(*obj);
         } else {
             if(!JS::Call(cx, vals[1], vals[0], args, &rval))