author | Jonathan Watt <jwatt@jwatt.org> |
Fri, 24 May 2013 18:32:33 +0100 | |
changeset 132972 | 297eccee61b5622a9bebbfc3b7fde91385a42a16 |
parent 132971 | 456a4acec4cd55bc4d4ba3e9932f6b84513dc417 |
child 132973 | d1b9087dd6898d34a774861c34e3e444817b841e |
push id | 28541 |
push user | jwatt@jwatt.org |
push date | Sat, 25 May 2013 10:04:26 +0000 |
treeherder | mozilla-inbound@297eccee61b5 [default view] [failures only] |
perfherder | [talos] [build metrics] [platform microbench] (compared to previous push) |
reviewers | roc |
bugs | 854765 |
milestone | 24.0a1 |
first release with | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
last release without | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
--- a/layout/svg/SVGFEContainerFrame.cpp +++ b/layout/svg/SVGFEContainerFrame.cpp @@ -39,18 +39,16 @@ public: #ifdef DEBUG NS_IMETHOD GetFrameName(nsAString& aResult) const { return MakeFrameName(NS_LITERAL_STRING("SVGFEContainer"), aResult); } #endif - virtual void DidSetStyleContext(nsStyleContext* aOldStyleContext); - #ifdef DEBUG virtual void Init(nsIContent* aContent, nsIFrame* aParent, nsIFrame* aPrevInFlow) MOZ_OVERRIDE; #endif /** * Get the "type" of the frame * @@ -71,23 +69,16 @@ public: nsIFrame* NS_NewSVGFEContainerFrame(nsIPresShell* aPresShell, nsStyleContext* aContext) { return new (aPresShell) SVGFEContainerFrame(aContext); } NS_IMPL_FRAMEARENA_HELPERS(SVGFEContainerFrame) -/* virtual */ void -SVGFEContainerFrame::DidSetStyleContext(nsStyleContext* aOldStyleContext) -{ - SVGFEContainerFrameBase::DidSetStyleContext(aOldStyleContext); - nsSVGEffects::InvalidateRenderingObservers(this); -} - #ifdef DEBUG void SVGFEContainerFrame::Init(nsIContent* aContent, nsIFrame* aParent, nsIFrame* aPrevInFlow) { NS_ASSERTION(aContent->IsNodeOfType(nsINode::eFILTER), "Trying to construct an SVGFEContainerFrame for a "
--- a/layout/svg/SVGFEImageFrame.cpp +++ b/layout/svg/SVGFEImageFrame.cpp @@ -43,18 +43,16 @@ public: #ifdef DEBUG NS_IMETHOD GetFrameName(nsAString& aResult) const { return MakeFrameName(NS_LITERAL_STRING("SVGFEImage"), aResult); } #endif - virtual void DidSetStyleContext(nsStyleContext* aOldStyleContext); - /** * Get the "type" of the frame * * @see nsGkAtoms::svgFEImageFrame */ virtual nsIAtom* GetType() const; NS_IMETHOD AttributeChanged(int32_t aNameSpaceID, @@ -71,23 +69,16 @@ nsIFrame* NS_NewSVGFEImageFrame(nsIPresShell* aPresShell, nsStyleContext* aContext) { return new (aPresShell) SVGFEImageFrame(aContext); } NS_IMPL_FRAMEARENA_HELPERS(SVGFEImageFrame) /* virtual */ void -SVGFEImageFrame::DidSetStyleContext(nsStyleContext* aOldStyleContext) -{ - SVGFEImageFrameBase::DidSetStyleContext(aOldStyleContext); - nsSVGEffects::InvalidateRenderingObservers(this); -} - -/* virtual */ void SVGFEImageFrame::DestroyFrom(nsIFrame* aDestructRoot) { nsCOMPtr<nsIImageLoadingContent> imageLoader = do_QueryInterface(SVGFEImageFrameBase::mContent); if (imageLoader) { imageLoader->FrameDestroyed(this); imageLoader->DecrementVisibleCount();
--- a/layout/svg/SVGFELeafFrame.cpp +++ b/layout/svg/SVGFELeafFrame.cpp @@ -42,18 +42,16 @@ public: #ifdef DEBUG NS_IMETHOD GetFrameName(nsAString& aResult) const { return MakeFrameName(NS_LITERAL_STRING("SVGFELeaf"), aResult); } #endif - virtual void DidSetStyleContext(nsStyleContext* aOldStyleContext); - /** * Get the "type" of the frame * * @see nsGkAtoms::svgFELeafFrame */ virtual nsIAtom* GetType() const; NS_IMETHOD AttributeChanged(int32_t aNameSpaceID, @@ -69,23 +67,16 @@ public: nsIFrame* NS_NewSVGFELeafFrame(nsIPresShell* aPresShell, nsStyleContext* aContext) { return new (aPresShell) SVGFELeafFrame(aContext); } NS_IMPL_FRAMEARENA_HELPERS(SVGFELeafFrame) -/* virtual */ void -SVGFELeafFrame::DidSetStyleContext(nsStyleContext* aOldStyleContext) -{ - SVGFELeafFrameBase::DidSetStyleContext(aOldStyleContext); - nsSVGEffects::InvalidateRenderingObservers(this); -} - #ifdef DEBUG void SVGFELeafFrame::Init(nsIContent* aContent, nsIFrame* aParent, nsIFrame* aPrevInFlow) { NS_ASSERTION(aContent->IsNodeOfType(nsINode::eFILTER), "Trying to construct an SVGFELeafFrame for a "
--- a/layout/svg/nsSVGForeignObjectFrame.cpp +++ b/layout/svg/nsSVGForeignObjectFrame.cpp @@ -113,33 +113,16 @@ nsSVGForeignObjectFrame::AttributeChange aAttribute == nsGkAtoms::preserveAspectRatio) { nsSVGEffects::InvalidateRenderingObservers(this); } } return NS_OK; } -/* virtual */ void -nsSVGForeignObjectFrame::DidSetStyleContext(nsStyleContext* aOldStyleContext) -{ - nsSVGForeignObjectFrameBase::DidSetStyleContext(aOldStyleContext); - - // No need to invalidate before first reflow - that will happen elsewhere. - // Moreover we haven't been initialised properly yet so we may not have the - // right state bits. - if (!(GetStateBits() & NS_FRAME_FIRST_REFLOW)) { - // XXXperf: probably only need a bounds update if 'font-size' changed and - // we have em unit width/height. Or, once we map 'transform' into style, - // if some transform property changed. - nsSVGEffects::InvalidateRenderingObservers(this); - nsSVGUtils::ScheduleReflowSVG(this); - } -} - NS_IMETHODIMP nsSVGForeignObjectFrame::Reflow(nsPresContext* aPresContext, nsHTMLReflowMetrics& aDesiredSize, const nsHTMLReflowState& aReflowState, nsReflowStatus& aStatus) { NS_ABORT_IF_FALSE(!(GetStateBits() & NS_STATE_SVG_NONDISPLAY_CHILD), "Should not have been called");
--- a/layout/svg/nsSVGForeignObjectFrame.h +++ b/layout/svg/nsSVGForeignObjectFrame.h @@ -34,18 +34,16 @@ public: virtual void Init(nsIContent* aContent, nsIFrame* aParent, nsIFrame* aPrevInFlow) MOZ_OVERRIDE; virtual void DestroyFrom(nsIFrame* aDestructRoot); NS_IMETHOD AttributeChanged(int32_t aNameSpaceID, nsIAtom* aAttribute, int32_t aModType); - virtual void DidSetStyleContext(nsStyleContext* aOldStyleContext) MOZ_OVERRIDE; - virtual nsIFrame* GetContentInsertionFrame() { return GetFirstPrincipalChild()->GetContentInsertionFrame(); } NS_IMETHOD Reflow(nsPresContext* aPresContext, nsHTMLReflowMetrics& aDesiredSize, const nsHTMLReflowState& aReflowState, nsReflowStatus& aStatus);
--- a/layout/svg/nsSVGGradientFrame.cpp +++ b/layout/svg/nsSVGGradientFrame.cpp @@ -52,23 +52,16 @@ nsSVGGradientFrame::nsSVGGradientFrame(n { } NS_IMPL_FRAMEARENA_HELPERS(nsSVGGradientFrame) //---------------------------------------------------------------------- // nsIFrame methods: -/* virtual */ void -nsSVGGradientFrame::DidSetStyleContext(nsStyleContext* aOldStyleContext) -{ - nsSVGEffects::InvalidateDirectRenderingObservers(this); - nsSVGGradientFrameBase::DidSetStyleContext(aOldStyleContext); -} - NS_IMETHODIMP nsSVGGradientFrame::AttributeChanged(int32_t aNameSpaceID, nsIAtom* aAttribute, int32_t aModType) { if (aNameSpaceID == kNameSpaceID_None && (aAttribute == nsGkAtoms::gradientUnits || aAttribute == nsGkAtoms::gradientTransform ||
--- a/layout/svg/nsSVGGradientFrame.h +++ b/layout/svg/nsSVGGradientFrame.h @@ -48,18 +48,16 @@ public: virtual already_AddRefed<gfxPattern> GetPaintServerPattern(nsIFrame *aSource, const gfxMatrix& aContextMatrix, nsStyleSVGPaint nsStyleSVG::*aFillOrStroke, float aGraphicOpacity, const gfxRect *aOverrideBounds); // nsIFrame interface: - virtual void DidSetStyleContext(nsStyleContext* aOldStyleContext); - NS_IMETHOD AttributeChanged(int32_t aNameSpaceID, nsIAtom* aAttribute, int32_t aModType); #ifdef DEBUG NS_IMETHOD GetFrameName(nsAString& aResult) const { return MakeFrameName(NS_LITERAL_STRING("SVGGradient"), aResult);
--- a/layout/svg/nsSVGMaskFrame.cpp +++ b/layout/svg/nsSVGMaskFrame.cpp @@ -126,23 +126,16 @@ nsSVGMaskFrame::ComputeMaskAlpha(nsRende nsSVGUtils::ComputeAlphaMask(data, stride, rect, aOpacity); } nsRefPtr<gfxPattern> retval = new gfxPattern(image); retval->SetMatrix(matrix); return retval.forget(); } -/* virtual */ void -nsSVGMaskFrame::DidSetStyleContext(nsStyleContext* aOldStyleContext) -{ - nsSVGEffects::InvalidateDirectRenderingObservers(this); - nsSVGMaskFrameBase::DidSetStyleContext(aOldStyleContext); -} - NS_IMETHODIMP nsSVGMaskFrame::AttributeChanged(int32_t aNameSpaceID, nsIAtom* aAttribute, int32_t aModType) { if (aNameSpaceID == kNameSpaceID_None && (aAttribute == nsGkAtoms::x || aAttribute == nsGkAtoms::y ||
--- a/layout/svg/nsSVGMaskFrame.h +++ b/layout/svg/nsSVGMaskFrame.h @@ -32,18 +32,16 @@ public: NS_DECL_FRAMEARENA_HELPERS // nsSVGMaskFrame method: already_AddRefed<gfxPattern> ComputeMaskAlpha(nsRenderingContext *aContext, nsIFrame* aParent, const gfxMatrix &aMatrix, float aOpacity = 1.0f); - virtual void DidSetStyleContext(nsStyleContext* aOldStyleContext); - NS_IMETHOD AttributeChanged(int32_t aNameSpaceID, nsIAtom* aAttribute, int32_t aModType); #ifdef DEBUG virtual void Init(nsIContent* aContent, nsIFrame* aParent, nsIFrame* aPrevInFlow) MOZ_OVERRIDE;
--- a/layout/svg/nsSVGPathGeometryFrame.cpp +++ b/layout/svg/nsSVGPathGeometryFrame.cpp @@ -115,31 +115,16 @@ nsSVGPathGeometryFrame::AttributeChanged (static_cast<nsSVGPathGeometryElement*> (mContent)->AttributeDefinesGeometry(aAttribute))) { nsSVGEffects::InvalidateRenderingObservers(this); nsSVGUtils::ScheduleReflowSVG(this); } return NS_OK; } -/* virtual */ void -nsSVGPathGeometryFrame::DidSetStyleContext(nsStyleContext* aOldStyleContext) -{ - nsSVGPathGeometryFrameBase::DidSetStyleContext(aOldStyleContext); - - // XXX: we'd like to use the style_hint mechanism and the - // ContentStateChanged/AttributeChanged functions for style changes - // to get slightly finer granularity, but unfortunately the - // style_hints don't map very well onto svg. Here seems to be the - // best place to deal with style changes: - - nsSVGEffects::InvalidateRenderingObservers(this); - nsSVGUtils::ScheduleReflowSVG(this); -} - nsIAtom * nsSVGPathGeometryFrame::GetType() const { return nsGkAtoms::svgPathGeometryFrame; } bool nsSVGPathGeometryFrame::IsSVGTransformed(gfxMatrix *aOwnTransform,
--- a/layout/svg/nsSVGPathGeometryFrame.h +++ b/layout/svg/nsSVGPathGeometryFrame.h @@ -51,18 +51,16 @@ public: NS_DECL_QUERYFRAME NS_DECL_FRAMEARENA_HELPERS // nsIFrame interface: NS_IMETHOD AttributeChanged(int32_t aNameSpaceID, nsIAtom* aAttribute, int32_t aModType); - virtual void DidSetStyleContext(nsStyleContext* aOldStyleContext); - /** * Get the "type" of the frame * * @see nsGkAtoms::svgPathGeometryFrame */ virtual nsIAtom* GetType() const; virtual bool IsSVGTransformed(gfxMatrix *aOwnTransforms = nullptr,
--- a/layout/svg/nsSVGPatternFrame.cpp +++ b/layout/svg/nsSVGPatternFrame.cpp @@ -57,23 +57,16 @@ nsSVGPatternFrame::nsSVGPatternFrame(nsS { } NS_IMPL_FRAMEARENA_HELPERS(nsSVGPatternFrame) //---------------------------------------------------------------------- // nsIFrame methods: -/* virtual */ void -nsSVGPatternFrame::DidSetStyleContext(nsStyleContext* aOldStyleContext) -{ - nsSVGEffects::InvalidateDirectRenderingObservers(this); - nsSVGPatternFrameBase::DidSetStyleContext(aOldStyleContext); -} - NS_IMETHODIMP nsSVGPatternFrame::AttributeChanged(int32_t aNameSpaceID, nsIAtom* aAttribute, int32_t aModType) { if (aNameSpaceID == kNameSpaceID_None && (aAttribute == nsGkAtoms::patternUnits || aAttribute == nsGkAtoms::patternContentUnits ||
--- a/layout/svg/nsSVGPatternFrame.h +++ b/layout/svg/nsSVGPatternFrame.h @@ -47,18 +47,16 @@ public: public: typedef mozilla::SVGAnimatedPreserveAspectRatio SVGAnimatedPreserveAspectRatio; // nsSVGContainerFrame methods: virtual gfxMatrix GetCanvasTM(uint32_t aFor); // nsIFrame interface: - virtual void DidSetStyleContext(nsStyleContext* aOldStyleContext); - NS_IMETHOD AttributeChanged(int32_t aNameSpaceID, nsIAtom* aAttribute, int32_t aModType); #ifdef DEBUG virtual void Init(nsIContent* aContent, nsIFrame* aParent, nsIFrame* aPrevInFlow) MOZ_OVERRIDE;
--- a/layout/svg/nsSVGStopFrame.cpp +++ b/layout/svg/nsSVGStopFrame.cpp @@ -35,18 +35,16 @@ public: nsIFrame* aParent, nsIFrame* aPrevInFlow) MOZ_OVERRIDE; #endif void BuildDisplayList(nsDisplayListBuilder* aBuilder, const nsRect& aDirtyRect, const nsDisplayListSet& aLists) MOZ_OVERRIDE {} - virtual void DidSetStyleContext(nsStyleContext* aOldStyleContext); - NS_IMETHOD AttributeChanged(int32_t aNameSpaceID, nsIAtom* aAttribute, int32_t aModType); /** * Get the "type" of the frame * * @see nsGkAtoms::svgStopFrame @@ -81,23 +79,16 @@ nsSVGStopFrame::Init(nsIContent* aConten nsIFrame* aPrevInFlow) { NS_ASSERTION(aContent->IsSVG(nsGkAtoms::stop), "Content is not a stop element"); nsSVGStopFrameBase::Init(aContent, aParent, aPrevInFlow); } #endif /* DEBUG */ -/* virtual */ void -nsSVGStopFrame::DidSetStyleContext(nsStyleContext* aOldStyleContext) -{ - nsSVGStopFrameBase::DidSetStyleContext(aOldStyleContext); - nsSVGEffects::InvalidateRenderingObservers(this); -} - nsIAtom * nsSVGStopFrame::GetType() const { return nsGkAtoms::svgStopFrame; } NS_IMETHODIMP nsSVGStopFrame::AttributeChanged(int32_t aNameSpaceID,