Bug 1059404 - Accept a dump save path when checking for crashes in DeviceRunner. r=ahalberstadt
authorDave Hunt <dhunt@mozilla.com>
Tue, 02 Sep 2014 09:26:00 +0200
changeset 203215 296fe203e6fd0835f02b6aa2037eaa490e1424ed
parent 203214 f75925c6b161ec1b51890caacc970aa543affe55
child 203216 f7f7e8683a87a49c049b204619eb1ab872d84ceb
push id48611
push usercbook@mozilla.com
push dateWed, 03 Sep 2014 08:45:15 +0000
treeherdermozilla-inbound@f7f7e8683a87 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersahalberstadt
bugs1059404
milestone35.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1059404 - Accept a dump save path when checking for crashes in DeviceRunner. r=ahalberstadt
testing/mozbase/mozrunner/mozrunner/base/device.py
--- a/testing/mozbase/mozrunner/mozrunner/base/device.py
+++ b/testing/mozbase/mozrunner/mozrunner/base/device.py
@@ -120,19 +120,22 @@ class DeviceRunner(BaseRunner):
             msg = "%s with no output" % msg
 
         print(msg % (self.last_test, timeout))
         self.check_for_crashes()
 
     def on_finish(self):
         self.check_for_crashes()
 
-    def check_for_crashes(self, test_name=None):
+    def check_for_crashes(self, dump_save_path=None, test_name=None):
         test_name = test_name or self.last_test
         dump_dir = self.device.pull_minidumps()
         crashed = BaseRunner.check_for_crashes(
-            self, dump_directory=dump_dir, test_name=test_name)
+            self,
+            dump_directory=dump_dir,
+            dump_save_path=dump_save_path,
+            test_name=test_name)
         mozfile.remove(dump_dir)
         return crashed
 
     def cleanup(self, *args, **kwargs):
         BaseRunner.cleanup(self, *args, **kwargs)
         self.device.cleanup()