Bug 1110461 - Disable estimated reading time in reading list. r=mcomella
authorMargaret Leibovic <margaret.leibovic@gmail.com>
Thu, 11 Dec 2014 13:44:49 -0800
changeset 219915 295f228e8a9bbc02d894d3525a8465feb78462d7
parent 219914 a7770ec46f0401c0a855e68f656ad8362be77ffc
child 219916 249dbdbe09e0ed9d6abe081289a76beb55e4b847
child 220072 c34f43a2a07270afd41cb004928f7814815e7a94
push id52946
push usercbook@mozilla.com
push dateTue, 16 Dec 2014 12:43:15 +0000
treeherdermozilla-inbound@df8db207bf66 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmcomella
bugs1110461
milestone37.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1110461 - Disable estimated reading time in reading list. r=mcomella
mobile/android/base/home/ReadingListRow.java
mobile/android/base/resources/layout/reading_list_row_view.xml
--- a/mobile/android/base/home/ReadingListRow.java
+++ b/mobile/android/base/home/ReadingListRow.java
@@ -56,23 +56,25 @@ public class ReadingListRow extends Line
         }
 
         final int titleIndex = cursor.getColumnIndexOrThrow(ReadingListItems.TITLE);
         title.setText(cursor.getString(titleIndex));
 
         final int excerptIndex = cursor.getColumnIndexOrThrow(ReadingListItems.EXCERPT);
         excerpt.setText(cursor.getString(excerptIndex));
 
+        /* Disabled until UX issues are fixed (see bug 1110461).
         final int lengthIndex = cursor.getColumnIndexOrThrow(ReadingListItems.LENGTH);
         final int minutes = getEstimatedReadTime(cursor.getInt(lengthIndex));
         if (minutes <= 60) {
             readTime.setText(resources.getString(R.string.reading_list_time_minutes, minutes));
         } else {
             readTime.setText(resources.getString(R.string.reading_list_time_over_an_hour));
         }
+        */
     }
 
     /**
      * Calculates the estimated time to read an article based on its length.
      *
      * @param length of the article (in characters)
      * @return estimated time to read the article (in minutes)
      */
--- a/mobile/android/base/resources/layout/reading_list_row_view.xml
+++ b/mobile/android/base/resources/layout/reading_list_row_view.xml
@@ -29,11 +29,12 @@
 
     </LinearLayout>
 
     <TextView
         android:id="@+id/read_time"
         android:layout_width="64dp"
         android:layout_height="match_parent"
         android:gravity="center"
+        android:visibility="gone"
         style="@style/Widget.ReadingListRow.ReadTime" />
 
 </merge>