Bug 1230617 - Editing text in an input field causes actionbar jank, r=snorp
authorMark Capella <markcapella@twcny.rr.com>
Mon, 14 Dec 2015 18:53:26 -0500
changeset 276445 28e50891e0b3eb108b09d6ce7adbf88dec21a776
parent 276444 f5f738d1702ec3ecf534bb0c7f7838790cdd6772
child 276446 5521a6be995b30853148187c5e6027de18709e5a
push id69162
push usercbook@mozilla.com
push dateTue, 15 Dec 2015 13:52:23 +0000
treeherdermozilla-inbound@98d65afd9826 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssnorp
bugs1230617
milestone45.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1230617 - Editing text in an input field causes actionbar jank, r=snorp
widget/android/nsWindow.cpp
--- a/widget/android/nsWindow.cpp
+++ b/widget/android/nsWindow.cpp
@@ -2358,17 +2358,16 @@ nsWindow::Natives::OnImeReplaceText(int3
         window.RemoveIMEComposition();
 
         {
             WidgetSelectionEvent event(true, eSetSelection, &window);
             window.InitEvent(event, nullptr);
             event.mOffset = uint32_t(aStart);
             event.mLength = uint32_t(aEnd - aStart);
             event.mExpandToClusterBoundary = false;
-            event.mReason = nsISelectionListener::IME_REASON;
             window.DispatchEvent(&event);
         }
 
         if (!mIMEKeyEvents.IsEmpty()) {
             nsEventStatus status;
             for (uint32_t i = 0; i < mIMEKeyEvents.Length(); i++) {
                 const auto event = static_cast<WidgetGUIEvent*>(
                         mIMEKeyEvents[i].get());
@@ -2487,17 +2486,16 @@ nsWindow::Natives::OnImeUpdateCompositio
 
         WidgetSelectionEvent selEvent(true, eSetSelection, &window);
         window.InitEvent(selEvent, nullptr);
 
         selEvent.mOffset = std::min(aStart, aEnd);
         selEvent.mLength = std::max(aStart, aEnd) - selEvent.mOffset;
         selEvent.mReversed = aStart > aEnd;
         selEvent.mExpandToClusterBoundary = false;
-        selEvent.mReason = nsISelectionListener::IME_REASON;
 
         window.DispatchEvent(&selEvent);
         return;
     }
 
     /*
         Update the composition from aStart to aEnd using
           information from added ranges. This is only used for