Bug 906901: Address review nit
☠☠ backed out by 26944521805d ☠ ☠
authorDavid Zbarsky <dzbarsky@gmail.com>
Fri, 23 Aug 2013 21:16:37 -0400
changeset 144181 27eb88629c56a03be0f441d89dc50947d861c398
parent 144180 a26582e3c44d04539477cb3a23abfbfdc33a45a0
child 144182 ff5fd513db35bbb6358d1d4aa934d0e6c5870227
push id32899
push userdzbarsky@gmail.com
push dateSat, 24 Aug 2013 01:15:07 +0000
treeherdermozilla-inbound@27eb88629c56 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs906901
milestone26.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 906901: Address review nit
dom/browser-element/BrowserElementParent.cpp
--- a/dom/browser-element/BrowserElementParent.cpp
+++ b/dom/browser-element/BrowserElementParent.cpp
@@ -67,17 +67,17 @@ CreateIframe(Element* aOpenerFrameElemen
                                        NS_LITERAL_STRING("false"),
                              /* aNotify = */ false);
 
   return popupFrameElement.forget();
 }
 
 bool
 DispatchCustomDOMEvent(Element* aFrameElement, const nsAString& aEventName,
-                       JSContext* cx, JS::Handle<JS::Value> aDetailValue)
+                       JSContext* aCx, JS::Handle<JS::Value> aDetailValue)
 {
   NS_ENSURE_TRUE(aFrameElement, false);
   nsIPresShell *shell = aFrameElement->OwnerDoc()->GetShell();
   nsRefPtr<nsPresContext> presContext;
   if (shell) {
     presContext = shell->GetPresContext();
   }
 
@@ -86,17 +86,17 @@ DispatchCustomDOMEvent(Element* aFrameEl
                                  NS_LITERAL_STRING("customevent"),
                                  getter_AddRefs(domEvent));
   NS_ENSURE_TRUE(domEvent, false);
 
   nsCOMPtr<nsIDOMCustomEvent> customEvent = do_QueryInterface(domEvent);
   NS_ENSURE_TRUE(customEvent, false);
   ErrorResult res;
   CustomEvent* event = static_cast<CustomEvent*>(customEvent.get());
-  event->InitCustomEvent(cx,
+  event->InitCustomEvent(aCx,
                          aEventName,
                          /* bubbles = */ true,
                          /* cancelable = */ false,
                          aDetailValue,
                          res);
   if (res.Failed()) {
     return false;
   }