Bug 1506604 - bind onDetachedFront to proper instance. r=pbro
authorJZ <yjzuo6@gmail.com>
Wed, 14 Nov 2018 14:37:26 -0500
changeset 446545 25325172bcc88d8a5a3c3c93164d54215148e704
parent 446544 588c3ba8cacdbefebe334ca5014c3891e851d12d
child 446546 4f32bb864539fde4affbcecb5b45e1b2d61591c5
push id109887
push usernerli@mozilla.com
push dateThu, 15 Nov 2018 13:56:19 +0000
treeherdermozilla-inbound@25325172bcc8 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerspbro
bugs1506604
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1506604 - bind onDetachedFront to proper instance. r=pbro
devtools/client/inspector/computed/computed.js
--- a/devtools/client/inspector/computed/computed.js
+++ b/devtools/client/inspector/computed/computed.js
@@ -1425,16 +1425,17 @@ SelectorView.prototype = {
 
 function ComputedViewTool(inspector, window) {
   this.inspector = inspector;
   this.document = window.document;
 
   this.computedView = new CssComputedView(this.inspector, this.document,
     this.inspector.pageStyle);
 
+  this.onDetachedFront = this.onDetachedFront.bind(this);
   this.onSelected = this.onSelected.bind(this);
   this.refresh = this.refresh.bind(this);
   this.onPanelSelected = this.onPanelSelected.bind(this);
 
   this.inspector.selection.on("detached-front", this.onDetachedFront);
   this.inspector.selection.on("new-node-front", this.onSelected);
   this.inspector.selection.on("pseudoclass", this.refresh);
   this.inspector.sidebar.on("computedview-selected", this.onPanelSelected);