Bug 1518053 [wpt PR 14733] - Css values fixes, a=testonly
authorGérard Talbot <github@gtalbot.org>
Thu, 31 Jan 2019 15:44:38 +0000
changeset 456852 2509717eb74258c2f2e9b0b105dd1d53543b369b
parent 456851 0e5f3ce027d62f9ab26d6665361e5adf57cd8ae3
child 456853 a100beb9ad422d4ca2018f178b4f5d9a61a57533
push id111705
push userjames@hoppipolla.co.uk
push dateTue, 05 Feb 2019 18:07:20 +0000
treeherdermozilla-inbound@9592b19c9b09 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1518053, 14733, 13930, 13834
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1518053 [wpt PR 14733] - Css values fixes, a=testonly Automatic update from web-platform-tests Merge branch 'FremyCompany-master' Trying to merge pull request 13930 which should fix the vh-support-margin test (see issue 13834) https://github.com/web-platform-tests/wpt/issues/13834 -- Merge remote-tracking branch 'upstream/master' -- Merge remote-tracking branch 'upstream/master' -- The original vh-support-atviewport.html test did not test what it claimed to be testing. Fantasai and I came up with this redesign and replacement. -- use more precise specification reference -- Merge pull request #14733 from TalbotG/css-values-fixes Css values fixes -- wpt-commits: f84da965417b060c742d3967a5051499638d8cb3, c50169dc6b7770f66da2592707d223f357f0557e, fe088dee6e8180860e59fadef73aba49526511d0, d5916f483cccc0f7d6195b1167e95184f56c8f07, 2730111e991e3e21d00c1dc3b4cf6809966716e0, b7d6508023db961126208844668236647169fe49 wpt-pr: 14733
testing/web-platform/tests/css/css-values/reference/vh-support-atviewport-ref.htm
testing/web-platform/tests/css/css-values/vh-support-atviewport.html
new file mode 100644
--- /dev/null
+++ b/testing/web-platform/tests/css/css-values/reference/vh-support-atviewport-ref.htm
@@ -0,0 +1,22 @@
+<!DOCTYPE html>
+<html><head>
+	<meta charset="utf-8">
+	<title>
+		CSS Reftest Reference
+	</title>
+
+	<link href="mailto:fremycompany.developer@yahoo.fr" rel="author" title="François REMY">
+
+	<style type="text/css">
+			html
+				{
+					background-color: yellow;
+					border-left: blue solid 50vw;
+					height: 100vh;
+				}
+	</style>
+
+</head>
+<body>
+
+</body></html>
\ No newline at end of file
--- a/testing/web-platform/tests/css/css-values/vh-support-atviewport.html
+++ b/testing/web-platform/tests/css/css-values/vh-support-atviewport.html
@@ -1,44 +1,41 @@
 <!DOCTYPE html>
-<html>
-<head>
+<html><head>
 	<meta charset="utf-8">
 	<title>
 		CSS Values and Units Test:
 		Viewports units are supported in @viewport rules
 	</title>
-	<meta name="assert" content="
+	<meta content="
 		Viewports units are supported in @viewport rules
-	" />
+	" name="assert">
 
-	<link
-		rel="author"
-		title="François REMY"
-		href="mailto:fremycompany.developer@yahoo.fr"
-	/>
+	<link href="mailto:fremycompany.developer@yahoo.fr" rel="author" title="François REMY">
 
-	<link rel="help" href="http://www.w3.org/TR/css3-values/#viewport-relative-lengths" />
-	<link rel="help" href="https://drafts.csswg.org/css-device-adapt-1/" />
+	<link href="http://www.w3.org/TR/css3-values/#viewport-relative-lengths" rel="help">
+	<link href="https://drafts.csswg.org/css-device-adapt-1/#atviewport-rule" rel="help">
 
-	<link
-		rel="match"
-		href="reference/all-green.html"
-	/>
+	<link href="reference/vh-support-atviewport-ref.htm" rel="match">
 
 	<style type="text/css">
-
-			html, body { margin: 0px; padding: 0px; overflow: hidden; }
+			html
+				{
+					background-color: yellow;
+				}
 
-			@viewport { width: 1vw; }
+			body
+				{
+					background-color: blue;
+					height: 100vh;
+					margin: 0;
+				}
 
-			html { background: red; }
-			#target { background: green; width: 100vw; height: 100vh; }
-
+			@viewport
+				{
+					width: 50vw;
+				}
 	</style>
 
 </head>
 <body>
 
-	<div id="target"></div>
-
-</body>
-</html>
+</body></html>
\ No newline at end of file