Bug 1394007 Fix a signedness comparison warning in WindowsDllBlocklist.cpp r=dmajor
authorTom Ritter <tom@mozilla.com>
Wed, 30 Aug 2017 00:43:46 -0500
changeset 377806 24653fcb748c603577c59c443b662394f7dca247
parent 377805 defa8a301a0aa93381ea86c17cec622c5ac35aee
child 377807 1575ef52aa22187b4cefbea002e19943fc2c7c93
push id94338
push userkwierso@gmail.com
push dateThu, 31 Aug 2017 02:58:58 +0000
treeherdermozilla-inbound@9ca18987dabb [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdmajor
bugs1394007
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1394007 Fix a signedness comparison warning in WindowsDllBlocklist.cpp r=dmajor MozReview-Commit-ID: 3qH0PU2gBur
mozglue/build/WindowsDllBlocklist.cpp
--- a/mozglue/build/WindowsDllBlocklist.cpp
+++ b/mozglue/build/WindowsDllBlocklist.cpp
@@ -515,17 +515,17 @@ DllBlockSet::Write(HANDLE file)
 
   // Because this method is called after a crash occurs, and uses heap memory,
   // protect this entire block with a structured exception handler.
   MOZ_SEH_TRY {
     DWORD nBytes;
     for (DllBlockSet* b = gFirst; b; b = b->mNext) {
       // write name[,v.v.v.v];
       WriteFile(file, b->mName, strlen(b->mName), &nBytes, nullptr);
-      if (b->mVersion != -1) {
+      if (b->mVersion != ALL_VERSIONS) {
         WriteFile(file, ",", 1, &nBytes, nullptr);
         uint16_t parts[4];
         parts[0] = b->mVersion >> 48;
         parts[1] = (b->mVersion >> 32) & 0xFFFF;
         parts[2] = (b->mVersion >> 16) & 0xFFFF;
         parts[3] = b->mVersion & 0xFFFF;
         for (int p = 0; p < 4; ++p) {
           char buf[32];