Bug 1407017 - Make --with-visual-studio-version a js_option. r=ted
authorDavid Major <dmajor@mozilla.com>
Mon, 09 Oct 2017 12:16:00 -0400
changeset 385217 244f2649c736dc5dc9652f9ab839cd3dc25cd820
parent 385216 5e0a1d82ef670c537b7b5c60ba0f2606a9f04ef7
child 385218 969e0b72c2eea55d49c3dc057ab3ccad1c1a1865
push id95945
push userryanvm@gmail.com
push dateMon, 09 Oct 2017 23:59:24 +0000
treeherdermozilla-inbound@969e0b72c2ee [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersted
bugs1407017
milestone58.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1407017 - Make --with-visual-studio-version a js_option. r=ted
build/moz.configure/toolchain.configure
--- a/build/moz.configure/toolchain.configure
+++ b/build/moz.configure/toolchain.configure
@@ -504,19 +504,19 @@ def get_vc_paths(topsrcdir):
         tools_version = open(os.path.join(path, r'VC\Auxiliary\Build\Microsoft.VCToolsVersion.default.txt'), 'rb').read().strip()
         tools_path = os.path.join(path, r'VC\Tools\MSVC', tools_version, r'bin\HostX64')
         yield (Version(install['installationVersion']), {
             'x64': [os.path.join(tools_path, 'x64')],
             # The x64->x86 cross toolchain requires DLLs from the native x64 toolchain.
             'x86': [os.path.join(tools_path, 'x86'), os.path.join(tools_path, 'x64')],
         })
 
-option('--with-visual-studio-version', nargs=1,
-       choices=('2015', '2017'),
-       help='Select a specific Visual Studio version to use')
+js_option('--with-visual-studio-version', nargs=1,
+          choices=('2015', '2017'),
+          help='Select a specific Visual Studio version to use')
 
 @depends('--with-visual-studio-version')
 def vs_major_version(value):
     if value:
         return {'2015': 14,
                 '2017': 15}[value[0]]
 
 @depends(host, target, vs_major_version, check_build_environment, '--with-visual-studio-version')