Bug 938242: Remove the visibility checks for touch actions in Marionette; r=mdas
authorDavid Burns <dburns@mozilla.com>
Wed, 27 Nov 2013 21:37:34 +0000
changeset 157822 234a044ca9425ea538eaec00cbb64d333529657d
parent 157821 c444703cff15b8b9fd951a91203aaecf273aa207
child 157823 499c81cdff30765f7a563c61faff15e56650119d
push id36853
push userdburns@mozilla.com
push dateWed, 27 Nov 2013 21:45:23 +0000
treeherdermozilla-inbound@234a044ca942 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmdas
bugs938242
milestone28.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 938242: Remove the visibility checks for touch actions in Marionette; r=mdas
testing/marionette/marionette-listener.js
--- a/testing/marionette/marionette-listener.js
+++ b/testing/marionette/marionette-listener.js
@@ -934,20 +934,16 @@ function actions(chain, touchId, command
   switch(command) {
     case 'press':
       if (lastCoordinates) {
         generateEvents('cancel', lastCoordinates[0], lastCoordinates[1], touchId);
         sendError("Invalid Command: press cannot follow an active touch event", 500, null, command_id);
         return;
       }
       el = elementManager.getKnownElement(pack[1], curFrame);
-      if (!checkVisible(el)) {
-         sendError("Element is not currently visible and may not be manipulated", 11, null, command_id);
-         return;
-      }
       c = coordinates(el, pack[2], pack[3]);
       touchId = generateEvents('press', c.x, c.y, null, el);
       actions(chain, touchId, command_id, i);
       break;
     case 'release':
       generateEvents('release', lastCoordinates[0], lastCoordinates[1], touchId);
       actions(chain, null, command_id, i);
       break;