Bug 1031949 - Crash in GonkDisplay::SwapBuffers() because Framebuffer tries to dup uninitialized Fence [SGS2][JB]. r=sotaro
authorJuan Gomez <atilag@gmail.com>
Sun, 29 Jun 2014 15:30:00 -0400
changeset 191606 21cf986ec9fbbd12228de6d4f3c8bcc3399821a0
parent 191605 e94590e830ff9c1ce826e54f8e1721ce5dec3394
child 191607 6c086c19b6b9022e087aa4073079d2d796d3d4a9
push id45618
push userkwierso@gmail.com
push dateTue, 01 Jul 2014 01:47:43 +0000
treeherdermozilla-inbound@d0787b1eebc1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssotaro
bugs1031949
milestone33.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1031949 - Crash in GonkDisplay::SwapBuffers() because Framebuffer tries to dup uninitialized Fence [SGS2][JB]. r=sotaro
widget/gonk/libdisplay/FramebufferSurface.cpp
--- a/widget/gonk/libdisplay/FramebufferSurface.cpp
+++ b/widget/gonk/libdisplay/FramebufferSurface.cpp
@@ -163,17 +163,17 @@ status_t FramebufferSurface::setReleaseF
             ALOGE_IF(err, "setReleaseFenceFd: failed to add the fence: %s (%d)",
                     strerror(-err), err);
         }
     }
     return err;
 }
 
 int FramebufferSurface::GetPrevFBAcquireFd() {
-  return mPrevFBAcquireFence->dup();
+  return mPrevFBAcquireFence.get() ? mPrevFBAcquireFence->dup() : -1;
 }
 
 status_t FramebufferSurface::setUpdateRectangle(const Rect& r)
 {
     return INVALID_OPERATION;
 }
 
 status_t FramebufferSurface::compositionComplete()