Bug 1209951 - Text cutoff in search suggestions if the text is longer than one row.r=mfinkle
authorAllison Naaktgeboren <ally@mozilla.com>
Thu, 01 Oct 2015 12:21:12 -0700
changeset 265702 21ae0d771356c908e3caae98e4e586538b5901db
parent 265701 f3fd4b1a12ec1953f5b8fa11f1cdf72e60d961da
child 265703 df3fb2045c1c23da5fa8cd20e3d454342de87d86
push id66003
push usercbook@mozilla.com
push dateFri, 02 Oct 2015 11:37:40 +0000
treeherdermozilla-inbound@3fd732d24f46 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmfinkle
bugs1209951
milestone44.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1209951 - Text cutoff in search suggestions if the text is longer than one row.r=mfinkle
mobile/android/base/resources/layout/search_engine_row.xml
mobile/android/base/resources/layout/suggestion_item.xml
--- a/mobile/android/base/resources/layout/search_engine_row.xml
+++ b/mobile/android/base/resources/layout/search_engine_row.xml
@@ -14,16 +14,17 @@
                                           android:minWidth="@dimen/favicon_bg"
                                           android:minHeight="@dimen/favicon_bg"/>
 
     <org.mozilla.gecko.widget.FlowLayout android:id="@+id/suggestion_layout"
                                          android:layout_toRightOf="@id/suggestion_icon"
                                          android:layout_centerVertical="true"
                                          android:layout_width="wrap_content"
                                          android:layout_height="wrap_content"
+                                         android:layout_marginRight="15dp"
                                          android:duplicateParentState="true">
 
         <include layout="@layout/suggestion_item"
                  android:id="@+id/suggestion_user_entered"/>
 
     </org.mozilla.gecko.widget.FlowLayout>
 
 </merge>
--- a/mobile/android/base/resources/layout/suggestion_item.xml
+++ b/mobile/android/base/resources/layout/suggestion_item.xml
@@ -1,18 +1,16 @@
 <?xml version="1.0" encoding="utf-8"?>
 <!-- This Source Code Form is subject to the terms of the Mozilla Public
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 
-<!-- For reasons unknown, the minHeight attribute is required to keep suggestion_user_entered the same size as all other
-     search suggestion buttons-->
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
               android:layout_width="wrap_content"
-              android:layout_height="32dp"
+              android:layout_height="wrap_content"
               android:minHeight="32dp"
               android:orientation="horizontal"
               android:background="@drawable/search_suggestion_button"
               android:gravity="center_vertical"
               android:clickable="true"
               android:padding="5dp">
 
     <ImageView android:id="@+id/suggestion_item_icon"