Backed out changeset bff13db4c158 (bug 1137593) for being the best guess of what's breaking Gij(20) a=backout CLOSED TREE
authorWes Kocher <wkocher@mozilla.com>
Wed, 13 May 2015 14:17:19 -0700
changeset 243820 1fab94ad196c2df18a96e966140b4ba572bdf9e9
parent 243819 dcc03921b9ce322387bc4182c485c81d3801ca88
child 243821 6ba4ce5105f74257f0f7d7e98aba5e4209cd333d
push id59786
push usereakhgari@mozilla.com
push dateThu, 14 May 2015 18:17:25 +0000
treeherdermozilla-inbound@2ef80cf97822 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbackout
bugs1137593
milestone41.0a1
backs outbff13db4c158899bc6da095b936f116a55d6b3e4
first release with
nightly linux32
1fab94ad196c / 41.0a1 / 20150514032200 / files
nightly linux64
1fab94ad196c / 41.0a1 / 20150514032200 / files
nightly mac
1fab94ad196c / 41.0a1 / 20150514032200 / files
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
releases
nightly linux32
nightly linux64
nightly mac
Backed out changeset bff13db4c158 (bug 1137593) for being the best guess of what's breaking Gij(20) a=backout CLOSED TREE
b2g/components/AlertsHelper.jsm
--- a/b2g/components/AlertsHelper.jsm
+++ b/b2g/components/AlertsHelper.jsm
@@ -227,26 +227,26 @@ let AlertsHelper = {
     try {
       let data = Cu.cloneInto(dataObj, {});
     } catch(e) { dataObj = null; }
 
     return dataObj;
   },
 
   showNotification: function(imageURL, title, text, textClickable, cookie,
-                             uid, dir, lang, dataObj, manifestURL, timestamp,
+                             uid, bidi, lang, dataObj, manifestURL, timestamp,
                              behavior) {
     function send(appName, appIcon) {
       SystemAppProxy._sendCustomEvent(kMozChromeNotificationEvent, {
         type: kDesktopNotification,
         id: uid,
         icon: imageURL,
         title: title,
         text: text,
-        dir: dir,
+        bidi: bidi,
         lang: lang,
         appName: appName,
         appIcon: appIcon,
         manifestURL: manifestURL,
         timestamp: timestamp,
         data: dataObj,
         mozbehavior: behavior
       });
@@ -271,17 +271,17 @@ let AlertsHelper = {
     let currentListener = this._listeners[data.name];
     if (currentListener && currentListener.observer) {
       currentListener.observer.observe(null, kTopicAlertFinished, currentListener.cookie);
     }
 
     let dataObj = this.deserializeStructuredClone(data.dataStr);
     this.registerListener(data.name, data.cookie, data.alertListener);
     this.showNotification(data.imageURL, data.title, data.text,
-                          data.textClickable, data.cookie, data.name, data.dir,
+                          data.textClickable, data.cookie, data.name, data.bidi,
                           data.lang, dataObj, null, data.inPrivateBrowsing);
   },
 
   showAppNotification: function(aMessage) {
     let data = aMessage.data;
     let details = data.details;
     let dataObject = this.deserializeStructuredClone(details.data);
     let listener = {