Bug 1260933 - Part 1: For invalid easing values, print the invalid value. r=birtles
authorDaisuke Akatsuka <daisuke@mozilla-japan.org>
Thu, 31 Mar 2016 19:20:42 +0900
changeset 291123 1ec5f90ead463d460c46523e1719695418ea8183
parent 291122 456df967efef1a9c621c9ededd6bf5530baedd7f
child 291124 2bcb11fae866b7d1446f6f0d2334f20bc6985c5b
push id74473
push userbbirtles@mozilla.com
push dateFri, 01 Apr 2016 03:08:35 +0000
treeherdermozilla-inbound@2bcb11fae866 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbirtles
bugs1260933
milestone48.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1260933 - Part 1: For invalid easing values, print the invalid value. r=birtles MozReview-Commit-ID: HJEjvGyUnCN
dom/animation/TimingParams.cpp
dom/bindings/Errors.msg
--- a/dom/animation/TimingParams.cpp
+++ b/dom/animation/TimingParams.cpp
@@ -156,17 +156,17 @@ TimingParams::ParseEasing(const nsAStrin
     case eCSSUnit_Unset:
     case eCSSUnit_TokenStream:
     case eCSSUnit_Null:
       break;
     default:
       MOZ_ASSERT_UNREACHABLE("unexpected animation-timing-function unit");
       break;
   }
-  aRv.ThrowTypeError<dom::MSG_INVALID_EASING_ERROR>();
+  aRv.ThrowTypeError<dom::MSG_INVALID_EASING_ERROR>(aEasing);
   return Nothing();
 }
 
 bool
 TimingParams::operator==(const TimingParams& aOther) const
 {
   return mDuration == aOther.mDuration &&
          mDelay == aOther.mDelay &&
--- a/dom/bindings/Errors.msg
+++ b/dom/bindings/Errors.msg
@@ -88,9 +88,9 @@ MSG_DEF(MSG_PROMISE_RESOLVE_FUNCTION_NOT
 MSG_DEF(MSG_PROMISE_REJECT_FUNCTION_NOT_CALLABLE, 0, JSEXN_TYPEERR, "A Promise subclass passed a non-callable value as the reject function.")
 MSG_DEF(MSG_PROMISE_ARG_NOT_ITERABLE, 1, JSEXN_TYPEERR, "{0} is not iterable")
 MSG_DEF(MSG_IS_NOT_PROMISE, 1, JSEXN_TYPEERR, "{0} is not a Promise")
 MSG_DEF(MSG_SW_INSTALL_ERROR, 2, JSEXN_TYPEERR, "ServiceWorker script at {0} for scope {1} encountered an error during installation.")
 MSG_DEF(MSG_SW_SCRIPT_THREW, 2, JSEXN_TYPEERR, "ServiceWorker script at {0} for scope {1} threw an exception during script evaluation.")
 MSG_DEF(MSG_TYPEDARRAY_IS_SHARED, 1, JSEXN_TYPEERR, "{0} can't be a typed array on SharedArrayBuffer")
 MSG_DEF(MSG_CACHE_ADD_FAILED_RESPONSE, 3, JSEXN_TYPEERR, "Cache got {0} response with bad status {1} while trying to add request {2}")
 MSG_DEF(MSG_INVALID_DURATION_ERROR, 0, JSEXN_TYPEERR, "Invalid duration.")
-MSG_DEF(MSG_INVALID_EASING_ERROR, 0, JSEXN_TYPEERR, "Invalid easing.")
\ No newline at end of file
+MSG_DEF(MSG_INVALID_EASING_ERROR, 1, JSEXN_TYPEERR, "Invalid easing '{0}'.")
\ No newline at end of file