author | Kris Maglione <maglione.k@gmail.com> |
Tue, 05 Sep 2017 11:20:43 -0700 | |
changeset 379322 | 1e4b5ec2904fcf7641a322480c45a4efd6da40da |
parent 379321 | ed7b5443cf8b98c807cd1fa29857b51511cd0076 |
child 379323 | 3b496e60f978d3ca2792c90ba01207cd7427aaf6 |
push id | 94643 |
push user | maglione.k@gmail.com |
push date | Thu, 07 Sep 2017 06:07:30 +0000 |
treeherder | mozilla-inbound@7282bbabab15 [default view] [failures only] |
perfherder | [talos] [build metrics] [platform microbench] (compared to previous push) |
reviewers | zombie |
bugs | 1396856 |
milestone | 57.0a1 |
first release with | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
last release without | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
toolkit/components/extensions/ExtensionCommon.jsm | file | annotate | diff | comparison | revisions | |
toolkit/components/extensions/ExtensionParent.jsm | file | annotate | diff | comparison | revisions |
--- a/toolkit/components/extensions/ExtensionCommon.jsm +++ b/toolkit/components/extensions/ExtensionCommon.jsm @@ -1561,36 +1561,36 @@ EventManager.prototype = { return true; } return false; }; let fire = { sync: (...args) => { if (shouldFire()) { - return this.context.runSafe(callback, ...args); + return this.context.applySafe(callback, args); } }, async: (...args) => { return Promise.resolve().then(() => { if (shouldFire()) { - return this.context.runSafe(callback, ...args); + return this.context.applySafe(callback, args); } }); }, raw: (...args) => { if (!shouldFire()) { throw new Error("Called raw() on unloaded/inactive context"); } - return callback(...args); + return Reflect.apply(callback, null, args); }, asyncWithoutClone: (...args) => { return Promise.resolve().then(() => { if (shouldFire()) { - return this.context.runSafeWithoutClone(callback, ...args); + return this.context.applySafeWithoutClone(callback, args); } }); }, }; let unregister = this.register(fire, ...args); this.unregister.set(callback, unregister);
--- a/toolkit/components/extensions/ExtensionParent.jsm +++ b/toolkit/components/extensions/ExtensionParent.jsm @@ -411,20 +411,20 @@ class ProxyContextParent extends BaseCon this.pendingEventBrowser = savedBrowser; } } get cloneScope() { return this.sandbox; } - runSafe(...args) { + applySafe(callback, args) { // There's no need to clone when calling listeners for a proxied // context. - return this.runSafeWithoutClone(...args); + return this.applySafeWithoutClone(callback, args); } get xulBrowser() { return this.messageManagerProxy.eventTarget; } get parentMessageManager() { return this.messageManagerProxy.messageManager;