Bug 774458 - Only send clicks on confirmed single taps, r=cjones
authorMichael Wu <mwu@mozilla.com>
Thu, 29 Nov 2012 21:26:11 -0500
changeset 114565 1ccaeeae85df1cfecf1e7f6ff3bfefefa6e06f3d
parent 114564 ce3e6613fe53ae4e1fcd5e0728b1e7f4b7c88c4f
child 114566 d2a0cc53acdcbd3cbc1d7aa35122a2d613f937c0
push id18836
push usermwu@mozilla.com
push dateFri, 30 Nov 2012 02:26:52 +0000
treeherdermozilla-inbound@1ccaeeae85df [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerscjones
bugs774458
milestone20.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 774458 - Only send clicks on confirmed single taps, r=cjones
gfx/layers/ipc/AsyncPanZoomController.cpp
--- a/gfx/layers/ipc/AsyncPanZoomController.cpp
+++ b/gfx/layers/ipc/AsyncPanZoomController.cpp
@@ -547,35 +547,34 @@ nsEventStatus AsyncPanZoomController::On
     mGeckoContentController->HandleLongTap(nsIntPoint(NS_lround(point.x),
                                                       NS_lround(point.y)));
     return nsEventStatus_eConsumeNoDefault;
   }
   return nsEventStatus_eIgnore;
 }
 
 nsEventStatus AsyncPanZoomController::OnSingleTapUp(const TapGestureInput& aEvent) {
+  return nsEventStatus_eIgnore;
+}
+
+nsEventStatus AsyncPanZoomController::OnSingleTapConfirmed(const TapGestureInput& aEvent) {
   if (mGeckoContentController) {
     MonitorAutoLock monitor(mMonitor);
 
     gfxFloat resolution = CalculateResolution(mFrameMetrics).width;
     gfx::Point point = WidgetSpaceToCompensatedViewportSpace(
       gfx::Point(aEvent.mPoint.x, aEvent.mPoint.y),
       resolution);
     mGeckoContentController->HandleSingleTap(nsIntPoint(NS_lround(point.x),
                                                         NS_lround(point.y)));
     return nsEventStatus_eConsumeNoDefault;
   }
   return nsEventStatus_eIgnore;
 }
 
-nsEventStatus AsyncPanZoomController::OnSingleTapConfirmed(const TapGestureInput& aEvent) {
-  // XXX: Implement this.
-  return nsEventStatus_eIgnore;
-}
-
 nsEventStatus AsyncPanZoomController::OnDoubleTap(const TapGestureInput& aEvent) {
   if (mGeckoContentController) {
     MonitorAutoLock monitor(mMonitor);
 
     if (mAllowZoom) {
       gfxFloat resolution = CalculateResolution(mFrameMetrics).width;
       gfx::Point point = WidgetSpaceToCompensatedViewportSpace(
         gfx::Point(aEvent.mPoint.x, aEvent.mPoint.y),