Bug 949891 - Make nsNumberControlFrame a leaf frame so that only its CreateAnonymousContent method can create child frames. r=dholbert
authorJonathan Watt <jwatt@jwatt.org>
Tue, 14 Jan 2014 12:40:01 +0000
changeset 164543 192c2dddd68f8c1605415dda377d68575999851f
parent 164542 03bdec48d0ac18016bf0e59b0357d8d45c0db903
child 164544 e844525de4ed3e63bce23367d263dd68a4250f0d
push id38743
push userjwatt@jwatt.org
push dateWed, 22 Jan 2014 01:34:23 +0000
treeherdermozilla-inbound@e844525de4ed [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdholbert
bugs949891
milestone29.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 949891 - Make nsNumberControlFrame a leaf frame so that only its CreateAnonymousContent method can create child frames. r=dholbert
layout/forms/crashtests/949891.xhtml
layout/forms/crashtests/crashtests.list
layout/forms/nsNumberControlFrame.h
new file mode 100644
--- /dev/null
+++ b/layout/forms/crashtests/949891.xhtml
@@ -0,0 +1,5 @@
+<html xmlns="http://www.w3.org/1999/xhtml">
+<body>
+<input type="number"> </input>
+</body>
+</html>
--- a/layout/forms/crashtests/crashtests.list
+++ b/layout/forms/crashtests/crashtests.list
@@ -48,9 +48,10 @@ skip-if(B2G) load 498698-1.html # bug 83
 asserts(1) load 578604-1.html # bug 584564
 asserts(4-7) load 590302-1.xhtml # bug 584564
 load 626014.xhtml
 load 639733.xhtml
 asserts(0-1) load 669767.html
 load 682684.xhtml
 load 865602.html
 load 944198.html
+load 949891.xhtml
 load 960277-2.html
--- a/layout/forms/nsNumberControlFrame.h
+++ b/layout/forms/nsNumberControlFrame.h
@@ -39,17 +39,17 @@ class nsNumberControlFrame MOZ_FINAL : p
 
 public:
   NS_DECL_QUERYFRAME_TARGET(nsNumberControlFrame)
   NS_DECL_QUERYFRAME
   NS_DECL_FRAMEARENA_HELPERS
 
   virtual void DestroyFrom(nsIFrame* aDestructRoot) MOZ_OVERRIDE;
   virtual void ContentStatesChanged(nsEventStates aStates);
-  virtual bool IsLeaf() const MOZ_OVERRIDE { return false; }
+  virtual bool IsLeaf() const MOZ_OVERRIDE { return true; }
 
 #ifdef ACCESSIBILITY
   virtual mozilla::a11y::AccType AccessibleType() MOZ_OVERRIDE;
 #endif
 
   NS_IMETHOD Reflow(nsPresContext*           aPresContext,
                     nsHTMLReflowMetrics&     aDesiredSize,
                     const nsHTMLReflowState& aReflowState,