Bug 1041632 - Part 2: eliminate enclosing instance member access of mProgressView in BrowserApp. r=ckitching
authorRichard Newman <rnewman@mozilla.com>
Mon, 21 Jul 2014 10:16:43 -0700
changeset 195365 159eea8f16838e2bec6adb7b7959b3f064b79985
parent 195364 79bd536c7ed2f6c8c402e0098de7f852019bea83
child 195366 0ca1c7de5bd411f80998bf5d26352715c167d06a
push id46575
push userkwierso@gmail.com
push dateTue, 22 Jul 2014 00:35:21 +0000
treeherdermozilla-inbound@fee5c4bdd713 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersckitching
bugs1041632
milestone33.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1041632 - Part 2: eliminate enclosing instance member access of mProgressView in BrowserApp. r=ckitching
mobile/android/base/BrowserApp.java
--- a/mobile/android/base/BrowserApp.java
+++ b/mobile/android/base/BrowserApp.java
@@ -1060,22 +1060,23 @@ public class BrowserApp extends GeckoApp
                     });
                 }
             }
         } else {
             mDynamicToolbarCanScroll = true;
         }
 
         final View toolbarLayout = mViewFlipper;
+        final ToolbarProgressView progressView = mProgressView;
         final int marginTop = Math.round(aMetrics.marginTop);
         ThreadUtils.postToUiThread(new Runnable() {
             public void run() {
                 final float translationY = marginTop - toolbarLayout.getHeight();
                 ViewHelper.setTranslationY(toolbarLayout, translationY);
-                ViewHelper.setTranslationY(mProgressView, translationY);
+                ViewHelper.setTranslationY(progressView, translationY);
 
                 if (mDoorHangerPopup.isShowing()) {
                     mDoorHangerPopup.updatePopup();
                 }
             }
         });
 
         if (mFormAssistPopup != null)