Bug 1479673 - Trivial return value change, r=jonco
authorSteve Fink <sfink@mozilla.com>
Wed, 11 Jul 2018 16:58:23 -0700
changeset 431263 12ddac0d1af4c9b0a24eef7dea6f10604c410697
parent 431262 9345ad05c0c590d9dae02c0d2e3b9903fc92985f
child 431264 fbbf72dcf1753b5921f395fe68e8730a1315a5a6
push id106401
push usersfink@mozilla.com
push dateMon, 13 Aug 2018 16:49:34 +0000
treeherdermozilla-inbound@07e7080fdf6c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjonco
bugs1479673
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1479673 - Trivial return value change, r=jonco JS::ubi::Concrete<T> inherits from JS::ubi::Base but not JS::ubi::Node, so the bare 'Size' in the class declaration refers to Base::Size, not Node::Size. (Note that they're the same underlying type.)
js/src/vm/JSScript.cpp
--- a/js/src/vm/JSScript.cpp
+++ b/js/src/vm/JSScript.cpp
@@ -4486,17 +4486,17 @@ JSScript::AutoDelazify::dropScript()
 {
     // Don't touch script_ if it's in the self-hosting realm, see the comment
     // in holdScript.
     if (script_ && !script_->realm()->isSelfHostingRealm())
         script_->setDoNotRelazify(oldDoNotRelazify_);
     script_ = nullptr;
 }
 
-JS::ubi::Node::Size
+JS::ubi::Base::Size
 JS::ubi::Concrete<JSScript>::size(mozilla::MallocSizeOf mallocSizeOf) const
 {
     Size size = Arena::thingSize(get().asTenured().getAllocKind());
 
     size += get().sizeOfData(mallocSizeOf);
     size += get().sizeOfTypeScript(mallocSizeOf);
 
     size_t baselineSize = 0;