Bug 1579424 - P5 module log for network link service in OSX, r=michal
authorJunior Hsu <juhsu@mozilla.com>
Tue, 12 Nov 2019 16:08:22 +0000
changeset 502271 1159b7bcfbd2f71f8dc326e3e66d2e0337a147af
parent 502270 bc41fd81784b182e71b5b13b9ec5cf29cbc8e88e
child 502272 09df60fc6e235e6d4c9594cc7edcb55cb82d460e
push id114172
push userdluca@mozilla.com
push dateTue, 19 Nov 2019 11:31:10 +0000
treeherdermozilla-inbound@b5c5ba07d3db [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmichal
bugs1579424
milestone72.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1579424 - P5 module log for network link service in OSX, r=michal Differential Revision: https://phabricator.services.mozilla.com/D48927
netwerk/system/mac/nsNetworkLinkService.mm
--- a/netwerk/system/mac/nsNetworkLinkService.mm
+++ b/netwerk/system/mac/nsNetworkLinkService.mm
@@ -368,17 +368,17 @@ static bool scanArp(char* ip, char* mac,
   mib[4] = NET_RT_FLAGS;
   mib[5] = RTF_LLINFO;
 
   size_t needed;
   if (sysctl(mib, 6, nullptr, &needed, nullptr, 0) < 0) {
     return false;
   }
   if (needed == 0) {
-    // empty table
+    LOG(("scanArp: empty table"));
     return false;
   }
 
   UniquePtr<char[]> buf(new char[needed]);
 
   for (;;) {
     st = sysctl(mib, 6, &buf[0], &needed, nullptr, 0);
     if (st == 0 || errno != ENOMEM) {
@@ -671,16 +671,17 @@ bool nsNetworkLinkService::IPv6NetworkId
             prefixAndNetmaskStore.push_back(prefixAndNetmask);
           }
         }
       }
     }
     freeifaddrs(ifap);
   }
   if (prefixAndNetmaskStore.empty()) {
+    LOG(("IPv6NetworkId failed"));
     return false;
   }
 
   nsNetworkLinkService::HashSortedPrefixesAndNetmasks(prefixAndNetmaskStore, sha1);
 
   return true;
 }