Bug 920397 part 2 - MessageChannel::~MessageChannel() now asserts that closing the handle succeeded. r=bsmedberg
authorMark Hammond <mhammond@skippinet.com.au>
Tue, 01 Oct 2013 10:56:16 +1000
changeset 149383 10c891d5b4e3b50c4dc5bec0f52f7d77b21ad615
parent 149382 571e97a6ae5442bad4cd2fffd5d0eebaad33e01a
child 149384 73e1b1a85886659994275723d88c864d01c5ea7a
push id34541
push usermhammond@skippinet.com.au
push dateTue, 01 Oct 2013 00:58:25 +0000
treeherdermozilla-inbound@73e1b1a85886 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbsmedberg
bugs920397
milestone27.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 920397 part 2 - MessageChannel::~MessageChannel() now asserts that closing the handle succeeded. r=bsmedberg
ipc/glue/MessageChannel.cpp
--- a/ipc/glue/MessageChannel.cpp
+++ b/ipc/glue/MessageChannel.cpp
@@ -71,17 +71,18 @@ MessageChannel::MessageChannel(MessageLi
 #endif
 }
 
 MessageChannel::~MessageChannel()
 {
     MOZ_COUNT_DTOR(ipc::MessageChannel);
     IPC_ASSERT(mCxxStackFrames.empty(), "mismatched CxxStackFrame ctor/dtors");
 #ifdef OS_WIN
-    CloseHandle(mEvent);
+    DebugOnly<BOOL> ok = CloseHandle(mEvent);
+    MOZ_ASSERT(ok);
 #endif
 }
 
 bool
 MessageChannel::Connected() const
 {
     mMonitor->AssertCurrentThreadOwns();