Bug 1168662 - Return AppConstants.ANDROID_PACKAGE_NAME w/ EXTRA_APPLICATION_ID. r=margaret
authorMichael Comella <michael.l.comella@gmail.com>
Wed, 17 Jun 2015 10:12:30 -0700
changeset 251107 109d5b02c4346d356b3b601d1e7992dd65923066
parent 251106 5d74c3c273f65b39bf63a8ad6d930d4883411e71
child 251108 bb16e4f42467957a2665128c913b49a4f8a1b1f5
push id61766
push usercbook@mozilla.com
push dateThu, 02 Jul 2015 13:47:40 +0000
treeherdermozilla-inbound@8ee689f2899a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmargaret
bugs1168662
milestone42.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1168662 - Return AppConstants.ANDROID_PACKAGE_NAME w/ EXTRA_APPLICATION_ID. r=margaret This is more appropriate than our internal org.mozilla.gecko package name as it provides the distinction across channels and has more public facing names than gecko.
mobile/android/base/GeckoAppShell.java
--- a/mobile/android/base/GeckoAppShell.java
+++ b/mobile/android/base/GeckoAppShell.java
@@ -1201,17 +1201,17 @@ public class GeckoAppShell
             if (!targetURI.startsWith("file:")) {
                 // Only handle applications which can accept arbitrary data from a browser.
                 intent.addCategory(Intent.CATEGORY_BROWSABLE);
             }
 
             // Some applications use this field to return to the same browser after processing the
             // Intent. While there is some danger (e.g. denial of service), other major browsers already
             // use it and so it's the norm.
-            intent.putExtra(Browser.EXTRA_APPLICATION_ID, GeckoApp.class.getPackage().getName());
+            intent.putExtra(Browser.EXTRA_APPLICATION_ID, AppConstants.ANDROID_PACKAGE_NAME);
         }
 
         return intent;
     }
 
     private static Intent getOpenURIIntentInner(final Context context,  final String targetURI,
             final String mimeType, final String action, final String title) {