Bug 1563685 - Rename WebSocketDebuggerTransport class to match its JSM file name. r=remote-protocol-reviewers,jdescottes,ato
☠☠ backed out by 2a5b1743e58a ☠ ☠
authorAlexandre Poirot <poirot.alex@gmail.com>
Mon, 08 Jul 2019 15:03:12 +0000
changeset 481662 10109cbe96417ef53f8a5f7560a4f5ce43dd70d3
parent 481661 6525d810b0b0314ef26075a570b41bcc19eee333
child 481663 addfd74916031a1a8bb926774a5c7856cf87ca7a
push id113632
push usernbeleuzu@mozilla.com
push dateTue, 09 Jul 2019 03:54:50 +0000
treeherdermozilla-inbound@d178951a5dcb [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersremote-protocol-reviewers, jdescottes, ato
bugs1563685
milestone69.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1563685 - Rename WebSocketDebuggerTransport class to match its JSM file name. r=remote-protocol-reviewers,jdescottes,ato Differential Revision: https://phabricator.services.mozilla.com/D37040
remote/Connection.jsm
remote/server/WebSocketTransport.jsm
remote/targets/Target.jsm
--- a/remote/Connection.jsm
+++ b/remote/Connection.jsm
@@ -16,17 +16,17 @@ XPCOMUtils.defineLazyServiceGetter(
   this,
   "UUIDGen",
   "@mozilla.org/uuid-generator;1",
   "nsIUUIDGenerator"
 );
 
 class Connection {
   /**
-   * @param WebSocketDebuggerTransport transport
+   * @param WebSocketTransport transport
    * @param httpd.js's Connection httpdConnection
    */
   constructor(transport, httpdConnection) {
     this.id = UUIDGen.generateUUID().toString();
     this.transport = transport;
     this.httpdConnection = httpdConnection;
 
     this.transport.hooks = this;
--- a/remote/server/WebSocketTransport.jsm
+++ b/remote/server/WebSocketTransport.jsm
@@ -1,31 +1,31 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 // This is an XPCOM service-ified copy of ../devtools/shared/transport/websocket-transport.js.
 
 "use strict";
 
-var EXPORTED_SYMBOLS = ["WebSocketDebuggerTransport"];
+var EXPORTED_SYMBOLS = ["WebSocketTransport"];
 
 const { EventEmitter } = ChromeUtils.import(
   "resource://gre/modules/EventEmitter.jsm"
 );
 
-function WebSocketDebuggerTransport(socket) {
+function WebSocketTransport(socket) {
   EventEmitter.decorate(this);
 
   this.active = false;
   this.hooks = null;
   this.socket = socket;
 }
 
-WebSocketDebuggerTransport.prototype = {
+WebSocketTransport.prototype = {
   ready() {
     if (this.active) {
       return;
     }
 
     this.socket.addEventListener("message", this);
     this.socket.addEventListener("close", this);
 
--- a/remote/targets/Target.jsm
+++ b/remote/targets/Target.jsm
@@ -4,17 +4,17 @@
 
 "use strict";
 
 var EXPORTED_SYMBOLS = ["Target"];
 
 const { Connection } = ChromeUtils.import(
   "chrome://remote/content/Connection.jsm"
 );
-const { WebSocketDebuggerTransport } = ChromeUtils.import(
+const { WebSocketTransport } = ChromeUtils.import(
   "chrome://remote/content/server/WebSocketTransport.jsm"
 );
 const { WebSocketHandshake } = ChromeUtils.import(
   "chrome://remote/content/server/WebSocketHandshake.jsm"
 );
 
 /**
  * Base class for all the Targets.
@@ -38,17 +38,17 @@ class Target {
       conn.close();
     }
   }
 
   // nsIHttpRequestHandler
 
   async handle(request, response) {
     const so = await WebSocketHandshake.upgrade(request, response);
-    const transport = new WebSocketDebuggerTransport(so);
+    const transport = new WebSocketTransport(so);
     const conn = new Connection(transport, response._connection);
     this.sessions.set(conn, new this.sessionClass(conn, this));
   }
 
   // XPCOM
 
   get QueryInterface() {
     return ChromeUtils.generateQI([Ci.nsIHttpRequestHandler]);