Bug 1584986 - P1 - Remove the early return for listInitializedOrigins; r=asuth
☠☠ backed out by f5d54343a43b ☠ ☠
authorTom Tung <ttung@mozilla.com>
Tue, 01 Oct 2019 13:10:27 +0000
changeset 495919 0fc3d50b822e943664129335ed99363da43ca7ea
parent 495918 49ef9afb62bb909389b105a1751e9b46e6f1688d
child 495920 ec44603ce08aa3e1ad8a01afdb335f6432ec7a3c
push id114140
push userdvarga@mozilla.com
push dateWed, 02 Oct 2019 18:04:51 +0000
treeherdermozilla-inbound@32eb0ea893f3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersasuth
bugs1584986
milestone71.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1584986 - P1 - Remove the early return for listInitializedOrigins; r=asuth Differential Revision: https://phabricator.services.mozilla.com/D47740
dom/quota/ActorsParent.cpp
dom/quota/test/unit/test_listInitializedOrigins.js
--- a/dom/quota/ActorsParent.cpp
+++ b/dom/quota/ActorsParent.cpp
@@ -9790,19 +9790,16 @@ bool ListInitializedOriginsOp::Init(Quot
 nsresult ListInitializedOriginsOp::DoDirectoryWork(
     QuotaManager* aQuotaManager) {
   AssertIsOnIOThread();
   MOZ_ASSERT(aQuotaManager);
 
   AUTO_PROFILER_LABEL("ListInitializedOriginsOp::DoDirectoryWork", OTHER);
 
   nsresult rv;
-  if (!aQuotaManager->IsTemporaryStorageInitialized()) {
-    return NS_OK;
-  }
 
   for (const PersistenceType type : kAllPersistenceTypes) {
     rv = TraverseRepository(aQuotaManager, type);
     if (NS_WARN_IF(NS_FAILED(rv))) {
       return rv;
     }
   }
 
--- a/dom/quota/test/unit/test_listInitializedOrigins.js
+++ b/dom/quota/test/unit/test_listInitializedOrigins.js
@@ -59,30 +59,16 @@ async function testSteps() {
       ok(a.origin == b.origin, "Origin equals");
     }
   }
 
   info("Creating test environment");
 
   await CreateTestEnvironment(origins);
 
-  info("Getting origins before initializing the storage");
-
-  await new Promise(resolve => {
-    listInitializedOrigins(request => {
-      verifyResult(request.result, []);
-      resolve();
-    });
-  });
-
-  info("Verifying result");
-
-  let request = initTemporaryStorage();
-  request = await requestFinished(request);
-
   info("Getting origins after initializing the storage");
 
   await new Promise(resolve => {
     listInitializedOrigins(req => {
       verifyResult(req.result, origins);
       resolve();
     });
   });