Bug 1504357 [wpt PR 14303] - [Gecko Bug 1504357] Make sure --repeat-until-unexpected doesn't loop over zero tests, a=testonly
authorWes Kocher <wkocher@mozilla.com>
Thu, 13 Dec 2018 13:57:25 +0000
changeset 450579 0f33ddfa45f60ff2297d79aa14910442511bb272
parent 450578 b658e04623b571a27ff5faa0c435a406eae74c13
child 450580 d8062a5a3bd5d2d9cc2e0d49865646652a627a7d
push id110514
push userwptsync@mozilla.com
push dateFri, 14 Dec 2018 13:59:55 +0000
treeherdermozilla-inbound@e225e62be2d6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1504357, 14303
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1504357 [wpt PR 14303] - [Gecko Bug 1504357] Make sure --repeat-until-unexpected doesn't loop over zero tests, a=testonly Automatic update from web-platform-tests Make sure --repeat-until-unexpected doesn't loop over zero tests If zero tests are selected to run while --repeat-until-unexpected is specified, wptrunner can get into a fast infinite loop of running nothing until killed by the user. This patch should stop that from happening by breaking the loop after the first iteration of nothing finishes. Differential Revision: https://phabricator.services.mozilla.com/D13204 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1504357 gecko-commit: f988af9437f591cc5c7d3917ba370e2edc82d1a6 gecko-integration-branch: central gecko-reviewers: jgraham -- Update wptrunner.py -- wpt-commits: ff755aa4b71299ecd172948a40f21c6ee0150371, f4449f82694932024c55f7e38b3328595f5c3aba wpt-pr: 14303
testing/web-platform/tests/tools/wptrunner/wptrunner/wptrunner.py
--- a/testing/web-platform/tests/tools/wptrunner/wptrunner/wptrunner.py
+++ b/testing/web-platform/tests/tools/wptrunner/wptrunner/wptrunner.py
@@ -280,17 +280,17 @@ def run_tests(config, test_paths, produc
 
                 test_total += test_count
                 unexpected_total += unexpected_count
                 logger.info("Got %i unexpected results" % unexpected_count)
                 logger.suite_end()
                 if repeat_until_unexpected and unexpected_total > 0:
                     break
                 if len(test_loader.test_ids) == skipped_tests:
-                    break;
+                    break
 
     if test_total == 0:
         if skipped_tests > 0:
             logger.warning("All requested tests were skipped")
         else:
             logger.error("No tests ran")
             return False